73869 - Installer - all-proxy.js is appended, not replaced

Status: RESOLVED WORKSFORME

(SeaMonkey :: Installer, defect)

Description

[[e-mail]]

Commercial build:
Win32 2001-03-28-09-Mtrunk

STEPS:
1- Using N6Setup.exe, select a proxy when installing.
2- Complete successful install.
3- Examine all-proxy.js

The file seems to have a set of prefs entries for each previous install, almost
like a log.

Bug 39015 describes the basic function of this feature, and from the reading, my
feeling is that the installer should over-write, rather than append an existing
all-proxy.js.

Comment 1

[Sean Su]

but does it pick up the last settings set?  The installer does not have a parser 
to search/replace strings in a file.

What happens if you run and quit mozilla.exe? do you still see multiple 
settings, or just one?

Comment 2

[[e-mail]]

I've been told that the prefs loader keeps only the last value for duplicate 
lines.

If all-proxy.js exists, then blow it away before writing the new values.

Comment 3

[Sean Su]

over to david.

Comment 4

[Grace Bush]

taking all proxy related bugs

Comment 5

[Grace Bush]

adding Ben to proxy bugs as requested

Comment 6

[benc]

Another example of some serious bustage:

While goofing around and installing mozilla on a friends computer, entered a
bogus hostname and no port value to see if it would failover to a direct connection.

The installer does run off the direct connection (b/c port==0), but then when
mozilla launches, it went deaf b/c it inhereted the port number of a previous
proxy install:

all-proxy.ja:

pref("network.proxy.http_port", 443);
pref("network.proxy.type", 1);
pref("network.proxy.http", "asdfasdf");
pref("network.proxy.type", 1);

Can't someone make a one-line change and blow the file away rather than append
the file? Totally easy, and easy to reproduce, for that matter.

Comment 7

[Syd Logan]

nsbeta1+ per buffy traige

Comment 8

[Syd Logan]

minusing for buffy triage

Comment 9

[benc]

-> defaults. I shouldn't be the owner.

Comment 10

[benc]

I'm going to see if I can get a patch for this.

Comment 11

[benc]

-> --

Comment 12

[benc]

Here's the source of the problem, the function originally appeneded to all.js.

bug 39015 comment 10.

Comment 13

[benc]

The problem is this line:

  if((fJSFile = fopen(szJSFile, "a+t")) != NULL)    

My c is very rusty, but all that needs to be done is to change it to create a
file instead of appending.

Comment 14

[benc]

Attachment: over-writes all-proxy.js, rather than appends

(I did not build this patch)

Comment 15

[Sean Su]

Comment on attachment 148052 [details] [diff] [review]
over-writes all-proxy.js, rather than appends

r=ssu

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 148052 [details] [diff] [review]
over-writes all-proxy.js, rather than appends

sr=dveditz

Comment 17

[Matthias Versen [:Matti]]

Seamonkey and Firefox are using a new NSIS based installer. resolving this old bug, please reopen if you still get this with the new installer