Last Comment Bug 738690 - [Azure] Properly convert patterns to userspace in Azure
: [Azure] Properly convert patterns to userspace in Azure
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: ---
Assigned To: Bas Schouten (:bas.schouten)
:
: Milan Sreckovic [:milan]
Mentors:
Depends on:
Blocks: 715768
  Show dependency treegraph
 
Reported: 2012-03-23 10:21 PDT by Bas Schouten (:bas.schouten)
Modified: 2012-05-20 13:41 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Deal with a changing pattern transform in the Azure wrapper (11.73 KB, patch)
2012-03-23 10:21 PDT, Bas Schouten (:bas.schouten)
jmuizelaar: review+
Details | Diff | Splinter Review

Description Bas Schouten (:bas.schouten) 2012-03-23 10:21:25 PDT
Created attachment 608747 [details] [diff] [review]
Deal with a changing pattern transform in the Azure wrapper

SVG font code can change the transform after having set the pattern on the context. When the pattern is set it is in user space, if the transform is changed after doing so the pattern needs to be converted back into userspace. We currently don't do this and it causes reftest failures inside SVG.

This patch deals with the situation, it tries to avoid doing work when not needed as best it can, but considering we often leave a pattern set while we change the transform in preparation of a new pattern it does regularly waste a copy of the transform into CurrentState().patternTransform. There's nothing we can do about that if we want the wrapper to be correct though.
Comment 1 Jeff Muizelaar [:jrmuizel] 2012-03-27 06:20:56 PDT
Comment on attachment 608747 [details] [diff] [review]
Deal with a changing pattern transform in the Azure wrapper

Review of attachment 608747 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/thebes/gfxContext.cpp
@@ +2074,5 @@
>    }
>  }
> +
> +void
> +gfxContext::TransformWillChange()

I think it's probably worth adding a summary of why this is need as a comment. Something like your original comment no the bug would be good.
Comment 2 Bas Schouten (:bas.schouten) 2012-03-29 11:57:48 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/23fb49402114
Comment 3 Ed Morley [:emorley] 2012-03-30 13:03:37 PDT
https://hg.mozilla.org/mozilla-central/rev/23fb49402114

Note You need to log in before you can comment on or make changes to this bug.