Remove some redundant and unused IME code: mComposing and returnIMEQueryResult

RESOLVED FIXED in Firefox 13

Status

()

Firefox for Android
Keyboards and IME
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
Firefox 14
ARM
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(firefox13 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
These patches chip away more IME cruft I stumbled upon when fixing other bugs.
(Assignee)

Updated

5 years ago
Component: General → IME
(Assignee)

Comment 1

5 years ago
Created attachment 608757 [details] [diff] [review]
bug-738695-part-1-remove-unused-returnIMQueryResult.patch

XUL Fennec uses returnIMEQueryResult() to get Gecko's selected text, but Native Fennec doesn't need this code because the Java code already knows the current selection.
Attachment #608757 - Flags: review?(blassey.bugs)
(Assignee)

Comment 2

5 years ago
Created attachment 608758 [details] [diff] [review]
bug-738695-part-2-unify-redundant-mComposing-mCompositionStart.patch

Unify redundant IME mComposing and mCompositionStart variables.
Attachment #608758 - Flags: review?(blassey.bugs)
Comment on attachment 608757 [details] [diff] [review]
bug-738695-part-1-remove-unused-returnIMQueryResult.patch

Review of attachment 608757 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +693,5 @@
>          GeckoApp.mAppContext.moveTaskToBack(true);
>      }
>  
>      public static void returnIMEQueryResult(String result, int selectionStart, int selectionLength) {
> +        // TODO: Remove returnIMEQueryResult() and corresponding JNI code when XUL Fennec is EOL'd.

remove this comment.
Attachment #608757 - Flags: review?(blassey.bugs) → review+
Attachment #608758 - Flags: review?(blassey.bugs) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 608858 [details] [diff] [review]
bug-738695-part-1-remove-unused-returnIMQueryResult-v2.patch

Removed TODO/EOL comment.

Carry forward r=blassey
Attachment #608757 - Attachment is obsolete: true
Attachment #608858 - Flags: review+
(Assignee)

Comment 5

5 years ago
checkin-needed for mozilla-central
Keywords: checkin-needed
(Assignee)

Comment 6

5 years ago
Comment on attachment 608858 [details] [diff] [review]
bug-738695-part-1-remove-unused-returnIMQueryResult-v2.patch

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: This is a code refactoring with no user visible changes.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Merging subsequent patches from m-c to m-a will be more difficult.
String changes made by this patch: None
Attachment #608858 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 7

5 years ago
Comment on attachment 608758 [details] [diff] [review]
bug-738695-part-2-unify-redundant-mComposing-mCompositionStart.patch

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: This is a code refactoring with no user visible changes.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Merging subsequent patches from m-c to m-a will be more difficult.
String changes made by this patch: None
Attachment #608758 - Flags: approval-mozilla-aurora?

Comment 8

5 years ago
Comment on attachment 608758 [details] [diff] [review]
bug-738695-part-2-unify-redundant-mComposing-mCompositionStart.patch

[Triage Comment]
Mobile only - approved for Aurora 13.
Attachment #608758 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Updated

5 years ago
Attachment #608858 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/integration/mozilla-inbound/rev/a7c227f347ea
https://hg.mozilla.org/integration/mozilla-inbound/rev/90f3a9a6e197
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/a7c227f347ea
https://hg.mozilla.org/mozilla-central/rev/90f3a9a6e197
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Comment 11

5 years ago
checkin-needed for mozilla-aurora
Keywords: checkin-needed
(Assignee)

Comment 12

5 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/ae195a8d5b23
https://hg.mozilla.org/releases/mozilla-aurora/rev/d53521e72555
Keywords: checkin-needed

Updated

5 years ago
status-firefox13: --- → fixed
You need to log in before you can comment on or make changes to this bug.