Closed Bug 738695 Opened 8 years ago Closed 8 years ago

Remove some redundant and unused IME code: mComposing and returnIMEQueryResult

Categories

(Firefox for Android :: Keyboards and IME, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

Details

Attachments

(2 files, 1 obsolete file)

These patches chip away more IME cruft I stumbled upon when fixing other bugs.
Component: General → IME
UL Fennec uses returnIMEQueryResult() to get Gecko's selected text, but Native Fennec doesn't need this code because the Java code already knows the current selection.
Attachment #608757 - Flags: review?(blassey.bugs)
Unify redundant IME mComposing and mCompositionStart variables.
Attachment #608758 - Flags: review?(blassey.bugs)
Comment on attachment 608757 [details] [diff] [review]
bug-738695-part-1-remove-unused-returnIMQueryResult.patch

Review of attachment 608757 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoAppShell.java
@@ +693,5 @@
>          GeckoApp.mAppContext.moveTaskToBack(true);
>      }
>  
>      public static void returnIMEQueryResult(String result, int selectionStart, int selectionLength) {
> +        // TODO: Remove returnIMEQueryResult() and corresponding JNI code when XUL Fennec is EOL'd.

remove this comment.
Attachment #608757 - Flags: review?(blassey.bugs) → review+
Attachment #608758 - Flags: review?(blassey.bugs) → review+
Removed TODO/EOL comment.

Carry forward r=blassey
Attachment #608757 - Attachment is obsolete: true
Attachment #608858 - Flags: review+
checkin-needed for mozilla-central
Keywords: checkin-needed
Comment on attachment 608858 [details] [diff] [review]
bug-738695-part-1-remove-unused-returnIMQueryResult-v2.patch

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: This is a code refactoring with no user visible changes.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Merging subsequent patches from m-c to m-a will be more difficult.
String changes made by this patch: None
Attachment #608858 - Flags: approval-mozilla-aurora?
Comment on attachment 608758 [details] [diff] [review]
bug-738695-part-2-unify-redundant-mComposing-mCompositionStart.patch

[Approval Request Comment]
Regression caused by (bug #): N/A
User impact if declined: This is a code refactoring with no user visible changes.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): Merging subsequent patches from m-c to m-a will be more difficult.
String changes made by this patch: None
Attachment #608758 - Flags: approval-mozilla-aurora?
Comment on attachment 608758 [details] [diff] [review]
bug-738695-part-2-unify-redundant-mComposing-mCompositionStart.patch

[Triage Comment]
Mobile only - approved for Aurora 13.
Attachment #608758 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #608858 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
checkin-needed for mozilla-aurora
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.