Last Comment Bug 738700 - xpc_UnmarkGrayObject should take nsISupports, not nsIXPConnectWrappedJS
: xpc_UnmarkGrayObject should take nsISupports, not nsIXPConnectWrappedJS
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Andrew McCreight [:mccr8]
:
Mentors:
Depends on:
Blocks: 737075
  Show dependency treegraph
 
Reported: 2012-03-23 10:37 PDT by Andrew McCreight [:mccr8]
Modified: 2012-03-29 08:47 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
WIP (5.79 KB, patch)
2012-03-23 13:37 PDT, Andrew McCreight [:mccr8]
no flags Details | Diff | Splinter Review
minor cleanup (5.78 KB, patch)
2012-03-28 13:01 PDT, Andrew McCreight [:mccr8]
bugs: review+
Details | Diff | Splinter Review

Description Andrew McCreight [:mccr8] 2012-03-23 10:37:51 PDT
Every existing caller of this function ends up QIing from nsISupports anyways, and I think the current setup requires the caller knowing what nsIXPConnectWrappedJS is, which is only available in some places.  This was giving me trouble when I was trying to call it in the observer service.  I'm also going to rename the function.
Comment 1 Andrew McCreight [:mccr8] 2012-03-23 13:37:22 PDT
Created attachment 608851 [details] [diff] [review]
WIP
Comment 2 Andrew McCreight [:mccr8] 2012-03-28 13:01:11 PDT
Created attachment 610260 [details] [diff] [review]
minor cleanup
Comment 3 Andrew McCreight [:mccr8] 2012-03-28 21:10:08 PDT
Comment on attachment 610260 [details] [diff] [review]
minor cleanup

Try run looked fine (same one as the other patch).
Comment 4 Andrew McCreight [:mccr8] 2012-03-28 21:53:46 PDT
Thanks for the reviews.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec1874ee6dc3
Comment 5 Matt Brubeck (:mbrubeck) 2012-03-29 08:47:53 PDT
https://hg.mozilla.org/mozilla-central/rev/ec1874ee6dc3

Note You need to log in before you can comment on or make changes to this bug.