xpc_UnmarkGrayObject should take nsISupports, not nsIXPConnectWrappedJS

RESOLVED FIXED in mozilla14

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Every existing caller of this function ends up QIing from nsISupports anyways, and I think the current setup requires the caller knowing what nsIXPConnectWrappedJS is, which is only available in some places.  This was giving me trouble when I was trying to call it in the observer service.  I'm also going to rename the function.
(Assignee)

Comment 1

6 years ago
Created attachment 608851 [details] [diff] [review]
WIP
Assignee: nobody → continuation
(Assignee)

Comment 2

6 years ago
Created attachment 610260 [details] [diff] [review]
minor cleanup
Attachment #608851 - Attachment is obsolete: true
(Assignee)

Comment 3

6 years ago
Comment on attachment 610260 [details] [diff] [review]
minor cleanup

Try run looked fine (same one as the other patch).
Attachment #610260 - Flags: review?(bugs)

Updated

6 years ago
Attachment #610260 - Flags: review?(bugs) → review+
(Assignee)

Comment 4

6 years ago
Thanks for the reviews.

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec1874ee6dc3
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/ec1874ee6dc3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.