738732 - Non-ASCII characters in bug summaries are mangled in securemail

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Jesse Ruderman]

The summary of bug 736210 was mangled in the securemail. (Viewed using Thunderbird + SMIME.)

Comment 1

[Gervase Markham [:gerv]]

Mangled in the Subject itself, or in the version of the Subject copied into the body? I'd assume the former if you are using SMIME...

Gerv

Comment 2

[Jesse Ruderman]

Mangled in the version of the Subject copied into the body. I don't know how to see the actual subject of the encrypted message.

Comment 3

[:glob ✱]

odd, works for me using postbox + s/mime from my dev system.
i'll retest on a staging environment once they are online.

Comment 4

[:glob ✱]

i can reproduce on stage-tip; will work on a minimal testcase.

Comment 5

[:glob ✱]

this problem happens when the subject contains a non-ascii character, however the changed data doesn't.

in this instance the email doesn't contain a content-transfer-encoding header, so when we stuff non-ascii characters into the body it doesn't get the correct encoding when it is subsequently read.

/me works on a patch

Comment 6

[:glob ✱]

Attachment: patch v1

Comment 7

[David Lawrence [:dkl]]

Comment on attachment 610155 [details] [diff] [review]
patch v1

Review of attachment 610155 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good and solves the issue for me (Thunderbird) r=dkl

Comment 8

[:glob ✱]

Committing to: bzr+ssh://[e-mail]/bmo/4.0/
modified extensions/SecureMail/Extension.pm
Committed revision 8115.

Committing to: bzr+ssh://[e-mail]/bmo/4.2/
modified extensions/SecureMail/Extension.pm
Committed revision 8102.