Closed
Bug 738740
Opened 13 years ago
Closed 13 years ago
Code from bug 737434 doesn't compile with clang
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: bzbarsky, Assigned: cwiiis)
References
Details
Attachments
(1 file)
|
2.12 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
../../../mozilla/gfx/gl/GLContext.cpp:1188:45: error: taking the address of a temporary object of type 'already_AddRefed<mozilla::gl::TextureImage>' [-Waddress-of-temporary]
mImages.ReplaceElementAt(i, &teximg.forget());
^~~~~~~~~~~~~~~~
|
Assignee | |
Comment 1•13 years ago
|
||
I've not finished a build yet, but the patch is quite trivial so uploading for review now.
Attachment #608808 -
Flags: review?(bzbarsky)
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 608808 [details] [diff] [review]
Fix nsTArray::ReplaceElementAt method
Oy. r=me
Attachment #608808 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Built and worked fine, pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/73db7a5e57f7
Status: NEW → ASSIGNED
|
|
||
Comment 4•13 years ago
|
||
Please can you set the target milestone when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-)
https://hg.mozilla.org/mozilla-central/rev/73db7a5e57f7
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in
before you can comment on or make changes to this bug.
Description
•