Last Comment Bug 738744 - "ASSERTION: Form controls should always have parents"
: "ASSERTION: Form controls should always have parents"
Status: RESOLVED FIXED
: assertion, testcase
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Mounir Lamouri (:mounir)
:
Mentors:
Depends on:
Blocks: 594645
  Show dependency treegraph
 
Reported: 2012-03-23 12:03 PDT by Jesse Ruderman
Modified: 2012-03-27 05:17 PDT (History)
2 users (show)
mounir: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
testcase (102 bytes, application/xhtml+xml)
2012-03-23 12:03 PDT, Jesse Ruderman
no flags Details
stack trace (2.29 KB, text/plain)
2012-03-23 12:03 PDT, Jesse Ruderman
no flags Details
Patch v1 (2.26 KB, patch)
2012-03-26 11:39 PDT, Mounir Lamouri (:mounir)
bzbarsky: review+
mounir: checkin+
Details | Diff | Review

Description Jesse Ruderman 2012-03-23 12:03:05 PDT
Created attachment 608806 [details]
testcase

###!!! ASSERTION: Form controls should always have parents: 'aControl1->GetParent() && aControl2->GetParent()', file content/html/content/src/nsHTMLFormElement.cpp, line 1057

I guess this assertion is as bogus as the one in bug 673853.
Comment 1 Jesse Ruderman 2012-03-23 12:03:24 PDT
Created attachment 608807 [details]
stack trace
Comment 2 Jesse Ruderman 2012-03-23 12:04:01 PDT
Pretty sure this assertion in nsFormControlList::AddElementToTable needs the same change:

      NS_ASSERTION(content->GetParent(), "Item in list without parent");
Comment 3 Mounir Lamouri (:mounir) 2012-03-26 11:39:35 PDT
Created attachment 609400 [details] [diff] [review]
Patch v1
Comment 4 Mounir Lamouri (:mounir) 2012-03-26 11:40:39 PDT
(In reply to Jesse Ruderman from comment #2)
> Pretty sure this assertion in nsFormControlList::AddElementToTable needs the
> same change:
> 
>       NS_ASSERTION(content->GetParent(), "Item in list without parent");

For some reasons I haven't been able to catch that assert. I don't want to waste too much time trying to figure out why so maybe we could just wait for the fuzzer to catch it?
Comment 5 Boris Zbarsky [:bz] 2012-03-26 15:09:04 PDT
Comment on attachment 609400 [details] [diff] [review]
Patch v1

r=me
Comment 6 Ed Morley [:emorley] 2012-03-27 05:17:58 PDT
https://hg.mozilla.org/mozilla-central/rev/127fdbb5639a

Note You need to log in before you can comment on or make changes to this bug.