738744 - "ASSERTION: Form controls should always have parents"

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Form controls should always have parents: 'aControl1->GetParent() && aControl2->GetParent()', file content/html/content/src/nsHTMLFormElement.cpp, line 1057

I guess this assertion is as bogus as the one in bug 673853.

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Jesse Ruderman]

Pretty sure this assertion in nsFormControlList::AddElementToTable needs the same change:

      NS_ASSERTION(content->GetParent(), "Item in list without parent");

Comment 3

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Comment 4

[Mounir Lamouri (:mounir)]

(In reply to Jesse Ruderman from comment #2)
> Pretty sure this assertion in nsFormControlList::AddElementToTable needs the
> same change:
> 
>       NS_ASSERTION(content->GetParent(), "Item in list without parent");

For some reasons I haven't been able to catch that assert. I don't want to waste too much time trying to figure out why so maybe we could just wait for the fuzzer to catch it?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 609400 [details] [diff] [review]
Patch v1

r=me

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/127fdbb5639a