Closed Bug 738744 Opened 8 years ago Closed 8 years ago

"ASSERTION: Form controls should always have parents"

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: jruderman, Assigned: mounir)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached file testcase
###!!! ASSERTION: Form controls should always have parents: 'aControl1->GetParent() && aControl2->GetParent()', file content/html/content/src/nsHTMLFormElement.cpp, line 1057

I guess this assertion is as bogus as the one in bug 673853.
Attached file stack trace
Pretty sure this assertion in nsFormControlList::AddElementToTable needs the same change:

      NS_ASSERTION(content->GetParent(), "Item in list without parent");
Attached patch Patch v1Splinter Review
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #609400 - Flags: review?(bzbarsky)
(In reply to Jesse Ruderman from comment #2)
> Pretty sure this assertion in nsFormControlList::AddElementToTable needs the
> same change:
> 
>       NS_ASSERTION(content->GetParent(), "Item in list without parent");

For some reasons I haven't been able to catch that assert. I don't want to waste too much time trying to figure out why so maybe we could just wait for the fuzzer to catch it?
Comment on attachment 609400 [details] [diff] [review]
Patch v1

r=me
Attachment #609400 - Flags: review?(bzbarsky) → review+
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla14
Attachment #609400 - Flags: checkin+
https://hg.mozilla.org/mozilla-central/rev/127fdbb5639a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.