"ASSERTION: Form controls should always have parents"

RESOLVED FIXED in mozilla14

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: mounir)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla14
assertion, testcase
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 608806 [details]
testcase

###!!! ASSERTION: Form controls should always have parents: 'aControl1->GetParent() && aControl2->GetParent()', file content/html/content/src/nsHTMLFormElement.cpp, line 1057

I guess this assertion is as bogus as the one in bug 673853.
(Reporter)

Comment 1

5 years ago
Created attachment 608807 [details]
stack trace
(Reporter)

Comment 2

5 years ago
Pretty sure this assertion in nsFormControlList::AddElementToTable needs the same change:

      NS_ASSERTION(content->GetParent(), "Item in list without parent");
(Assignee)

Comment 3

5 years ago
Created attachment 609400 [details] [diff] [review]
Patch v1
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #609400 - Flags: review?(bzbarsky)
(Assignee)

Comment 4

5 years ago
(In reply to Jesse Ruderman from comment #2)
> Pretty sure this assertion in nsFormControlList::AddElementToTable needs the
> same change:
> 
>       NS_ASSERTION(content->GetParent(), "Item in list without parent");

For some reasons I haven't been able to catch that assert. I don't want to waste too much time trying to figure out why so maybe we could just wait for the fuzzer to catch it?
Comment on attachment 609400 [details] [diff] [review]
Patch v1

r=me
Attachment #609400 - Flags: review?(bzbarsky) → review+
(Assignee)

Updated

5 years ago
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla14
(Assignee)

Updated

5 years ago
Attachment #609400 - Flags: checkin+

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/127fdbb5639a
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.