738755 - can't create new releases through Balrog API

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rail Aliiev [:rail]]

$ /tools/python-2.6.5/bin/python /builds/slave/m-cen-lnx64-ntly/tools/scripts/updates/balrog-client.py --build-properties buildprops_balrog.json --api-root https://aus4-admin-dev.allizom.org --credentials-file BuildSlaves.py --dummy --verbose
Balrog request to https://aus4-admin-dev.allizom.org/releases/Firefox-mozilla-central-dummy-nightly-20120323110322/builds/Linux_x86_64-gcc3/en-US
Data sent: {'product': u'Firefox', 'version': u'14.0a1', 'details': '{"buildID": "20120323110322", "appv": "14.0a1", "complete": {"fileUrl": "http://dev-stage01.build.sjc1.mozilla.com/pub/mozilla.org/firefox/nightly/2012/03/2012-03-23-11-03-22-mozilla-central/firefox-14.0a1.en-US.linux-x86_64.complete.mar", "hashValue": "055379f02b9e243c7062b924a126cb9860dfe8a1d2f92ebcd1b8b77bce356cba7b478cfb5bb1d607b3df74e341cf4830345518be1cde927a7c810944a51fdb54", "from": "*", "filesize": "20826037"}, "extv": "14.0a1"}', 'copy_to': "[u'Firefox-mozilla-central-dummy-nightly-latest']"}
Starting new HTTPS connection (1): aus4-admin-dev.allizom.org
"PUT /releases/Firefox-mozilla-central-dummy-nightly-20120323110322/builds/Linux_x86_64-gcc3/en-US HTTP/1.1" 500 541
Traceback (most recent call last):
  File "/builds/slave/m-cen-lnx64-ntly/tools/scripts/updates/balrog-client.py", line 37, in <module>
    runner.run()
  File "/builds/slave/m-cen-lnx64-ntly/tools/lib/python/balrog/client/cli.py", line 84, in run
    details=blob, copy_to=copy_to)
  File "/builds/slave/m-cen-lnx64-ntly/tools/lib/python/balrog/client/api.py", line 45, in update_build
    return self.request(method='PUT', url=url, data=data)
  File "/builds/slave/m-cen-lnx64-ntly/tools/lib/python/balrog/client/api.py", line 33, in request
    verify=self.verify, auth=self.auth)
  File "/builds/slave/m-cen-lnx64-ntly/tools/lib/python/vendor/requests-0.10.8/requests/api.py", line 39, in request
    return s.request(method=method, url=url, **kwargs)
  File "/builds/slave/m-cen-lnx64-ntly/tools/lib/python/vendor/requests-0.10.8/requests/sessions.py", line 203, in request
    r.send(prefetch=prefetch)
  File "/builds/slave/m-cen-lnx64-ntly/tools/lib/python/vendor/requests-0.10.8/requests/models.py", line 585, in send
    self.response.raise_for_status()
  File "/builds/slave/m-cen-lnx64-ntly/tools/lib/python/vendor/requests-0.10.8/requests/models.py", line 816, in raise_for_status
    raise http_error
requests.exceptions.HTTPError: 500 Server Error

Comment 1

[[e-mail] (:bhearsum)]

On the server side we get:
ERROR:auslib.web.base:Exception on /releases/Firefox-mozilla-central-dummy-nightly-20120323110322/builds/Linux_x86_64-gcc3/en-US [PUT]
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/flask/app.py", line 1292, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/lib/python2.6/site-packages/flask/app.py", line 1062, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/lib/python2.6/site-packages/flask/app.py", line 1060, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/lib/python2.6/site-packages/flask/app.py", line 1047, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/lib/python2.6/site-packages/flask/views.py", line 56, in view
    return self.dispatch_request(*args, **kwargs)
  File "/usr/lib/python2.6/site-packages/flask/views.py", line 112, in dispatch_request
    return meth(*args, **kwargs)
  File "/data/www/aus4-admin-dev.allizom.org/aus4-admin/auslib/web/views/base.py", line 40, in put
    return self._put(*args, transaction=trans, **kwargs)
  File "/data/www/aus4-admin-dev.allizom.org/aus4-admin/auslib/web/views/base.py", line 40, in put
    return self._put(*args, transaction=trans, **kwargs)
  File "/data/www/aus4-admin-dev.allizom.org/aus4-admin/auslib/web/views/base.py", line 11, in decorated
    return f(*args, changed_by=username, **kwargs)
  File "/data/www/aus4-admin-dev.allizom.org/aus4-admin/auslib/web/views/base.py", line 27, in decorated
    return f(*args, **kwargs)
  File "/data/www/aus4-admin-dev.allizom.org/aus4-admin/auslib/web/views/releases.py", line 36, in _put
    releaseObj = db.releases.getReleases(name=rel, transaction=transaction)[0]
IndexError: list index out of range


I'm pretty sure what's happening here is that getReleases() is trying to find the named release, and can't. Because we're trying to index the result we get an IndexError which is never caught, resulting in an ISA 500.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: catch IndexError, add test

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 609305 [details] [diff] [review]
catch IndexError, add test

Landed. Jenkins run is here: https://jenkins.mozilla.org/job/Balrog/63/