738759 - Add nsContentUtils::CheckSameOrigin overload taking two nsINodes

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Quite a few callers want an nsINode anyway.

Comment 1

[Johnny Stenback (:jst)]

Comment on attachment 608828 [details] [diff] [review]
Patch v1

-    case nsIDOMNode::ENTITY_NODE:
-    case nsIDOMNode::ENTITY_REFERENCE_NODE:
-    case nsIDOMNode::NOTATION_NODE:
-    {
-      return NS_ERROR_NOT_IMPLEMENTED;
-    }
     default:
     {
       NS_WARNING("Don't know how to clone this nodetype for importNode.");
 
       return NS_ERROR_DOM_NOT_SUPPORTED_ERR;
     }

This is of course an observable change in behavior here. Correct as it is, we should keep an eye out for odd fallout from this.

r=jst

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Johnny Stenback (:jst, [e-mail]) from comment #1)
> Comment on attachment 608828 [details] [diff] [review]
> Patch v1
> 
> -    case nsIDOMNode::ENTITY_NODE:
> -    case nsIDOMNode::ENTITY_REFERENCE_NODE:
> -    case nsIDOMNode::NOTATION_NODE:
> -    {
> -      return NS_ERROR_NOT_IMPLEMENTED;
> -    }
>      default:
>      {
>        NS_WARNING("Don't know how to clone this nodetype for importNode.");
>  
>        return NS_ERROR_DOM_NOT_SUPPORTED_ERR;
>      }
> 
> This is of course an observable change in behavior here. Correct as it is,
> we should keep an eye out for odd fallout from this.

How so? If it's an nsINode, it can't return any of these values through GetNodeType(). (At least, I sure hope so!) If it's not, we already threw from nsContentUtils::CheckSameOrigin(nsINode*, nsIDOMNode*).

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/66101542ba09