Closed Bug 738760 Opened 8 years ago Closed 8 years ago

Move nsContentUtils::GetContextAndScope into nsDocument.cpp

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch Patch v1Splinter Review
It's not like this code is so general anyone else would use it.
Attachment #608830 - Flags: review?(bobbyholley+bmo)
Comment on attachment 608830 [details] [diff] [review]
Patch v1

I'll let Jonas decide whether he wants this in nsContentUtils or not.

Jonas - this is a 30 second review, just FYI.
Attachment #608830 - Flags: review?(bobbyholley+bmo) → review?(jonas)
Comment on attachment 608830 [details] [diff] [review]
Patch v1

Review of attachment 608830 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed

::: content/base/public/nsContentUtils.h
@@ -258,5 @@
> -   * @param aNewDocument The document to get aNewScope from.
> -   * @param aCx [out] Context gotten through one of the scopes, from the stack
> -   *                  or the safe context.
> -   * @param aNewScope [out] Scope gotten from aNewDocument.
> -   */

Move this comment to above the static function.
Attachment #608830 - Flags: review?(jonas) → review+
https://hg.mozilla.org/mozilla-central/rev/c0d3b3b6e2fb
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla14
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.