The default bug view has changed. See this FAQ.

Move nsContentUtils::GetContextAndScope into nsDocument.cpp

RESOLVED FIXED in mozilla14

Status

()

Core
DOM
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 608830 [details] [diff] [review]
Patch v1

It's not like this code is so general anyone else would use it.
Attachment #608830 - Flags: review?(bobbyholley+bmo)
Comment on attachment 608830 [details] [diff] [review]
Patch v1

I'll let Jonas decide whether he wants this in nsContentUtils or not.

Jonas - this is a 30 second review, just FYI.
Attachment #608830 - Flags: review?(bobbyholley+bmo) → review?(jonas)
Comment on attachment 608830 [details] [diff] [review]
Patch v1

Review of attachment 608830 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed

::: content/base/public/nsContentUtils.h
@@ -258,5 @@
> -   * @param aNewDocument The document to get aNewScope from.
> -   * @param aCx [out] Context gotten through one of the scopes, from the stack
> -   *                  or the safe context.
> -   * @param aNewScope [out] Scope gotten from aNewDocument.
> -   */

Move this comment to above the static function.
Attachment #608830 - Flags: review?(jonas) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/c0d3b3b6e2fb
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.