738760 - Move nsContentUtils::GetContextAndScope into nsDocument.cpp

Status: RESOLVED FIXED

Description

[:Ms2ger (⌚ UTC+1/+2)]

Created attachment 608830 [details] [diff] [review]
Patch v1

It's not like this code is so general anyone else would use it.

Comment 1

[Bobby Holley (:bholley) (busy with Stylo)]

Comment on attachment 608830 [details] [diff] [review]
Patch v1

I'll let Jonas decide whether he wants this in nsContentUtils or not.

Jonas - this is a 30 second review, just FYI.

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 608830 [details] [diff] [review]
Patch v1

Review of attachment 608830 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with that fixed

::: content/base/public/nsContentUtils.h
@@ -258,5 @@
> -   * @param aNewDocument The document to get aNewScope from.
> -   * @param aCx [out] Context gotten through one of the scopes, from the stack
> -   *                  or the safe context.
> -   * @param aNewScope [out] Scope gotten from aNewDocument.
> -   */

Move this comment to above the static function.

Comment 3

[:Ms2ger (⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/c0d3b3b6e2fb