738767 - Addons label in View Quota is not localizable and displayed in English

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Francesco Lodolo [:flod]]

Attachment: Screenshot of View Quota on Italian build

Some users on our support forum made me notice this issue: there's an untranslated label in View Quota for "Addons".

In browser/chrome/browser/syncQuota.properties I don't see any string related to "Addons", I'm also browsing the code but I can't find anything useful.

Comment 1

[Francesco Lodolo [:flod]]

Screenshot taken on Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:14.0) Gecko/20120323 Firefox/14.0a1 (Italian Build).

I've also verified a French build of Firefox 11 and it's there as well, so definitely a non localizable string.

Comment 2

[Allison Naaktgeboren :ally]

Also noteworthy: The Engines tikibox list uses 'Add-ons' and this string is 'Addons' which is inconsistent with the rest of the UI

Comment 3

[Allison Naaktgeboren :ally]

also reproducing on aurora

Comment 4

[Richard Newman [:rnewman]]

It's there in the DTD:

<!ENTITY engine.addons.label        "Add-ons">
<!ENTITY engine.addons.accesskey    "A">

and it's used for prefs:

base/content/sync/setup.xul
412:            <checkbox label="&engine.addons.label;"

components/preferences/sync.xul
132:                  <checkbox label="&engine.addons.label;"


The title should also be used for quota:

  _collectionTitle: function _collectionTitle(engine) {
    try {
      return gSyncQuota.bundle.getString(
        "collection." + engine.prefName + ".label");
    } catch (ex) {
      return engine.Name;
    }
  },

Because engine.prefName is right:

--
[14:34:26.905] Engines.get("addons").prefName
[14:34:26.908] "addons"

Comment 5

[Francesco Lodolo [:flod]]

@richard
> It's there in the DTD
I'm not really good at reading code, but for what I understand it searches for "collection.addons.label", fails and use engine.prefName instead.

I'd expect a collection.addons.label=Add-ons here
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/syncQuota.properties

Comment 6

[Axel Hecht [:Pike]]

Yeah, I ended up at the same spot as flod.

Comment 7

[Francesco Lodolo [:flod]]

Attachment: Fix unlocalizable "addons" label

From a quick test the logic is exactly what I thought in comment 5, so adding a label "collection.addons.label" should be enough to fix this.

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 613159 [details] [diff] [review]
Fix unlocalizable "addons" label

Review of attachment 613159 [details] [diff] [review]:
-----------------------------------------------------------------

Trying with a different reviewer. 

It would be great if this patch could land before the next transition from central to aurora, since it should be very low risk.

Comment 9

[Marco Bonardo [:mak]]

Comment on attachment 613159 [details] [diff] [review]
Fix unlocalizable "addons" label

Review of attachment 613159 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/syncQuota.properties
@@ +2,2 @@
>  collection.bookmarks.label = Bookmarks
>  collection.history.label   = History

the patch looks correct, though the indentation is not (see next lines, the "=" are aligned, so you need some more spacing to align). r=me with that fixed.

Comment 10

[Richard Newman [:rnewman]]

> the patch looks correct, though the indentation is not (see next lines, the
> "=" are aligned, so you need some more spacing to align). r=me with that
> fixed.

Concur. Also, you'll need to set approval-mozilla-central after uploading a corrected patch.

Mobile/release drivers: this is a trivial fix, very low risk, that improves some minor UX for non-en users.

Comment 11

[Francesco Lodolo [:flod]]

Attachment: Updated patch with correct spacing (r+ :mak on previous patch)

Comment 12

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/03a334471fa3

Comment 13

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/03a334471fa3

Comment 14

[Francesco Lodolo [:flod]]

Verified on Mozilla/5.0 (X11; Linux x86_64; rv:14.0) Gecko/20120420 Firefox/14.0a1

Thank you guys ;-)