Closed Bug 738804 Opened 8 years ago Closed 8 years ago

back out keyword.URL prompting changes

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14
Tracking Status
firefox13 + fixed

People

(Reporter: Gavin, Assigned: Gavin)

Details

(Whiteboard: [qa-])

Attachments

(2 files)

Bug 718088 implemented a prompt for users whose keyword.URL pref was user-set. In discussing the approach taken in that bug, Asa/Sheila/Kev and I decided that we should focus first on consolidating our search prefs and making search engine selection more intuitive, before we start actively prompting users.

We're going to investigate other ways to help users whose searches were hijacked, and so it makes sense to get our search configuration story into a better state before we use up precious user-prompting opportunities.
Attached patch backoutSplinter Review
This is a straight backout of the patches for bug 718088 and bug 736878, merged with the patch for bug 697006.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #608874 - Flags: review?(fryn)
Comment on attachment 608874 [details] [diff] [review]
backout

Review of attachment 608874 [details] [diff] [review]:
-----------------------------------------------------------------

r+, with the fixed indentation. :)

Please cc me on future bugs that come out of this further investigation of search prefs.

::: browser/components/nsBrowserGlue.js
@@ -289,3 @@
>          }
> -        break;
> -    }

I think you might have removed the wrong closing brace, but syntactically it happened to work, or at least that's what Mercurial is telling me. :P Either way, please fix the indentation.
Attachment #608874 - Flags: review?(fryn) → review+
https://hg.mozilla.org/mozilla-central/rev/5bdd055f22b5
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Please prepare a backout for Aurora 13 as well. Thanks!
Attached patch aurora backoutSplinter Review
[Approval Request Comment]
Bug 736878 didn't land on Aurora, so this is a clean backout of the original patch for bug 718088 (again, merged with bug 697006, and the brace merging issue fixed!).
Attachment #611892 - Flags: approval-mozilla-aurora?
Comment on attachment 611892 [details] [diff] [review]
aurora backout

[Triage Comment]
Approved for Aurora 13.
Attachment #611892 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This changed strings, but only removed them, so this is fine. Worth calling that out, though.
Not sure if this is anything QA needs to verify so marking [qa-]. Please add [qa+] if there is something we can do here.
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.