The default bug view has changed. See this FAQ.

FormAssistant null error when Fennec is in background

VERIFIED FIXED in Firefox 14

Status

()

Firefox for Android
General
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

unspecified
Firefox 14
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 608909 [details] [diff] [review]
patch

window.content may be null if the tab isn't active. While a page is loading, if it's put in the background, JS will give this error:

03-23 11:17:55.956 10081 10091 E GeckoConsole: [JavaScript Error: "content is null" {file: "chrome://browser/content/browser.js" line: 2934}]

Rather than using content.document, I think we can use BrowserApp.selectedBrowser.contentDocument, which doesn't change if the tab is active/inactive.
Attachment #608909 - Flags: review?(mark.finkle)
Attachment #608909 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 1

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/68c598b9c6bc
Please can you set the target milestone when landing on inbound, along the lines of http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing :-)

https://hg.mozilla.org/mozilla-central/rev/68c598b9c6bc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
This wasn't marked as a blocker.  Should we be working on things like this right now?
(In reply to Damon Sicore (:damons) from comment #3)
> This wasn't marked as a blocker.  Should we be working on things like this
> right now?

It was found during work on blockers. JS errors have a tendency to just cause parts of the app to stop working. Brain (and others) have periodically run out of blockers, so I was fine with this fix.
https://hg.mozilla.org/releases/mozilla-aurora/rev/2940c6c8ef66
status-firefox13: --- → fixed
status-firefox14: --- → fixed
Error is no longer seen in the logs on Nightly 16.0a1 2012-06-12 and Aurora 15.0a2 2012-06-11 on HTC Desire running Android 2.2. Closing the issue as verified.
Status: RESOLVED → VERIFIED
status-firefox13: fixed → ---
status-firefox14: fixed → ---
You need to log in before you can comment on or make changes to this bug.