[Azure] [Quartz] ctx.mozDash does not support odd number of items

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: yury, Assigned: jrmuizel)

Tracking

Trunk
mozilla14
x86_64
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 608992 [details]
Minimal test case for odd mozDash

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:14.0) Gecko/20120323 Firefox/14.0a1

The even number items in the dash works, but not odd. Works in FF11.

(see https://github.com/mozilla/pdf.js/issues/1398)

Comment 1

5 years ago
Disabling gfx.canvas.azure.enabled fixes this problem.
Blocks: 715768
Component: Canvas: 2D → Graphics
QA Contact: canvas.2d → thebes
Summary: ctx.mozDash does not support odd number of items → [Azure] ctx.mozDash does not support odd number of items
Assignee: nobody → jmuizelaar
Summary: [Azure] ctx.mozDash does not support odd number of items → [Azure] [Quartz] ctx.mozDash does not support odd number of items
(Assignee)

Comment 2

5 years ago
Created attachment 609505 [details] [diff] [review]
Accept dash arrays of length >0

I copied the skia code here and took it's bug. This fixes the CG version and puts a note into the skia code.
(Assignee)

Updated

5 years ago
Attachment #609505 - Flags: review?(matt.woodrow)
Attachment #609505 - Flags: review?(matt.woodrow) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f9b7201c29d
(Assignee)

Comment 4

5 years ago
Created attachment 609591 [details] [diff] [review]
Reftest that catches this
Attachment #609591 - Flags: review?(matt.woodrow)
Attachment #609591 - Flags: review?(matt.woodrow) → review+

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/3f9b7201c29d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/f2e02f954e78
(Assignee)

Comment 7

5 years ago
Comment on attachment 609505 [details] [diff] [review]
Accept dash arrays of length >0

[Approval Request Comment]
Regression caused by (bug #): 692879
User impact if declined: Sometimes we'll dash incorrectly. This is most likely to show up with pdf.js because it requires using the mozDash addition to canvas which is relatively new.
Testing completed (on m-c, etc.): Tested on m-c
Risk to taking this patch (and alternatives if risky): Very low.
String changes made by this patch: none
Attachment #609505 - Flags: approval-mozilla-aurora?
Attachment #609505 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
No longer blocks: 715768
Blocks: 715768
You need to log in before you can comment on or make changes to this bug.