Closed Bug 738919 Opened 12 years ago Closed 12 years ago

[Azure] [Quartz] ctx.mozDash does not support odd number of items

Categories

(Core :: Graphics, defect)

Product:
Core
Component:
Graphics
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: yury, Assigned: jrmuizel)

References

Details

Attachments

(3 files)

Minimal test case for odd mozDash
298 bytes, text/html
Details
Accept dash arrays of length >0
1.38 KB, patch
mattwoodrow
: review+
lsblakk
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Reftest that catches this
1.25 KB, patch
mattwoodrow
: review+
Details | Diff | Splinter Review 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:14.0) Gecko/20120323 Firefox/14.0a1

The even number items in the dash works, but not odd. Works in FF11.

(see https://github.com/mozilla/pdf.js/issues/1398)
Disabling gfx.canvas.azure.enabled fixes this problem.
Blocks: 715768
Component: Canvas: 2D → Graphics
QA Contact: canvas.2d → thebes
Summary: ctx.mozDash does not support odd number of items → [Azure] ctx.mozDash does not support odd number of items
Assignee: nobody → jmuizelaar
Summary: [Azure] ctx.mozDash does not support odd number of items → [Azure] [Quartz] ctx.mozDash does not support odd number of items
I copied the skia code here and took it's bug. This fixes the CG version and puts a note into the skia code.
Attachment #609505 - Flags: review?(matt.woodrow)
Attachment #609505 - Flags: review?(matt.woodrow) → review+

        Attachment #609591 -
        Flags: review?(matt.woodrow)

        Attachment #609591 -
        Flags: review?(matt.woodrow) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/3f9b7201c29d
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14

    
    

    
  
Comment on attachment 609505 [details] [diff] [review]
Accept dash arrays of length >0

[Approval Request Comment]
Regression caused by (bug #): 692879
User impact if declined: Sometimes we'll dash incorrectly. This is most likely to show up with pdf.js because it requires using the mozDash addition to canvas which is relatively new.
Testing completed (on m-c, etc.): Tested on m-c
Risk to taking this patch (and alternatives if risky): Very low.
String changes made by this patch: none

        Attachment #609505 -
        Flags: approval-mozilla-aurora?

        Attachment #609505 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
No longer blocks: 715768

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: