739038 - Window.print() causes weird issues, making Fennec unusable

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

Similar bugs, bug 735237 and bug 707385.

See testcase, when visiting that testcase, window.print() is invoked. After that, Fennec behaves weird. You can't navigate to any page anymore, basically.

Tested on the Galaxy Nexus, Android 4.0.2.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch

This patch makes window.print throw an exception in Fennec, similar to the patch in bug 735237.

Note: This patch applies on top of the patch from bug 735237.  (They don't depend on each other functionally; they just touch nearby lines of code.)

Comment 2

[Matt Brubeck (:mbrubeck)]

Pushed to Try: https://tbpl.mozilla.org/?tree=Try&rev=339284aba55e

Comment 3

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b9133ddb15c2

Comment 4

[Matt Brubeck (:mbrubeck)]

Attachment: tests

Oops!  I included these tests in my push to Try (comment 2), but I attached (and landed) old copies of my patches that didn't include the tests.  Here are some simple mochitests for this bug and bug 735237.

Comment 5

[Matt Brubeck (:mbrubeck)]

Landed tests as a follow-up:
https://hg.mozilla.org/integration/mozilla-inbound/rev/362fd0d7c8c3

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/362fd0d7c8c3

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

And

https://hg.mozilla.org/mozilla-central/rev/b9133ddb15c2

Comment 8

[Cristian Nicolae (:xti)]

2 errors are thrown when the test page is opened on the latest Nightly:

E/GeckoConsole(25117): [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must to be declared in the document or in the transfer protocol." {file: "https://bug511883.bugzilla.mozilla.org/attachment.cgi?id=395841" line: 0}]

E/GeckoConsole(25117): [JavaScript Error: "NS_ERROR_NOT_AVAILABLE: Component returned failure code: 0x80040111 (NS_ERROR_NOT_AVAILABLE) [nsIDOMWindow.print]" {file: "data:text/html;charset=utf-8,%3Cscript%3Ewindow.print%28%29%3B%3C/script%3E" line: 1}]

Since both are expected, I will close this bug as verified fixed on:

Firefox 15.0a1 (2012-05-30)
Device: Galaxy Nexus
OS: Android 4.0.2