739066 - Empty thumbnail (about:blank) entries on about:home and blank rows added to Top Sites after clearing history

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

After clearing browser history, about:home will display (4) blank thumbnails in portrait with URL targets about:blank, and (3) in landscape.

Is this a recent intentional change to the top-sites behaviour on about:home?
 
--
Samsung Galaxy Nexus (Android 4.0.2)
Nightly (03/25)
Mozilla/5.0 (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0a1

Comment 1

[Aaron Train [:aaronmt]]

Yikes, clearing history after creating a new profile also generates various completely blank rows in 'Top Sites' in the AwesomeScreen. This feels like a regression.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Just to clarify: about:home home should show nothing after clearing history. The bug is that thumbnails are being show at all, not that they are blank.

Comment 3

[Aaron Train [:aaronmt]]

(also adding the entries to the home-screen results in a stringless star-icon)

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Don't include delete bookmarks/history in Combined view

Comment 5

[Lucas Rocha (:lucasr)]

Regression from bug 721731. Combined view should not include deleted bookmarks/history entries.

Comment 6

[:Margaret Leibovic]

Comment on attachment 610905 [details] [diff] [review]
Don't include delete bookmarks/history in Combined view

Aw, I was really hoping we would get this right the first time, but good catch!

Comment 7

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/integration/mozilla-inbound/rev/61964245b303

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/61964245b303

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7d59ec72a07c

Comment 10

[Cristian Nicolae (:xti)]

This issue doesn't occur any more on the latest Nightly. There aren't any blank entries in  Awesomelist or blank thumbnails on about:home.

Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-22)
Firefox 14.0a2 (2012-05-22)

Device: Galaxy Nexus
OS: Android 4.0.2