Closed
Bug 73917
Opened 24 years ago
Closed 24 years ago
cache entry data size not updated
Categories
(Core :: Networking: Cache, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9
People
(Reporter: darin.moz, Assigned: beard)
Details
(Whiteboard: [cache] fix checked into DISKCACHE1_BRANCH)
Attachments
(1 file)
|
858 bytes,
patch
|
Details | Diff | Splinter Review |
cache entries in the disk cache report data size == 0. for the disk cache,
i can verify that this is not the case. this is critical as it causes HTTP
to never read data from the cache.
I take it that this is connected to the
WARNING: Cached data size does not match the Content-Length header, file
nsHTTPChannel.cpp, line 1140
messages that flood my console.
regression, dogfood, ... ;-)
|
Assignee | |
Comment 3•24 years ago
|
||
This was caused by a change in how the dirty flags of the entry are maintained. I
believe it used to be the case that we simply marked the entry dirty
(IsEntryDirty()) when the data size changed. Now we mark the IsDataDirty() flag
true when we change the size. Enclosing a patch to fix this. I'm checking this
into the branch and will check in on trunk after I get a review.
|
|
Assignee | |
Comment 4•24 years ago
|
||
|
|
Assignee | |
Comment 5•24 years ago
|
||
Can I get an r/sr?
Whiteboard: [cache] fix checked into DISKCACHE1_BRANCH
|
|
Assignee | |
Updated•24 years ago
|
Target Milestone: --- → mozilla0.9
|
|
Reporter | |
Comment 7•24 years ago
|
||
sr=darin
I agree that this is a blocker level since all numbers generated would be way
off... we are only writing to disk and not reading/using the cache. I am marking
this smoketest
Keywords: smoketest
|
|
Reporter | |
Comment 9•24 years ago
|
||
fix checked in
You need to log in
before you can comment on or make changes to this bug.
Description
•