739179 - Provide test for strong table landmark "application" in test_aria_roles.html

Status: NEW

(Core :: Disability Access APIs, defect)

Description

[Mark Capella [:capella]]

Weak landmarks in test_aria_roles.html have _table tests in place. 

Strong landmark "Application" has orphaned _table definition with no test, possibly overlooked in Bug 469688.

Comment 1

[Veeraya Pupatwibul]

Attachment: patch

is it something like this? I tried running the test using the command 
TEST_PATH=accessible/tests/mochitest/test_aria_roles.html make -C $(OBJDIR) mochitest-plain
but got an error saying "404 Not Found."
How can I check if what I added into the source file is correct?

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 612107 [details] [diff] [review]
patch

Yes, this is the right function call. However I'm not sure I understand what you're trying to call here on the command line. The tes harness is a chrome test harness, so mochitest-plain may just be the wrong argument here.

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 612107 [details] [diff] [review]
patch

Review of attachment 612107 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment fixed

::: accessible/tests/mochitest/test_aria_roles.html
@@ +35,5 @@
>  
>        // strong landmark
>        testRole("application", ROLE_APPLICATION);
>        testRole("form", ROLE_FORM);
> +      testRole("application_table", ROLE_TABLE);

nah, it's strong landmark, I think it should be exposed as ROLE_APPLICATION

Comment 4

[alexander :surkov (:asurkov)]

(In reply to Veeraya Pupatwibul from comment #1)
> Created attachment 612107 [details] [diff] [review]
> patch
> 
> is it something like this? I tried running the test using the command 
> TEST_PATH=accessible/tests/mochitest/test_aria_roles.html make -C $(OBJDIR)
> mochitest-plain
> but got an error saying "404 Not Found."
> How can I check if what I added into the source file is correct?

I use another way to start a11y mochitest:
cd yourobjdir/_tests/testing/mochitest;
python runtests.py --a11y --test-path=accessible/test_aria_roles.html

Comment 5

[Mike Hoye [:mhoye]]

Can you confirm that you're still working on this bug?

Comment 6

[Mike Hoye [:mhoye]]

Been a long time here - deassigning, throwing back in the pool.

Comment 7

[Saurabh Singhal [:saurabhs]]

Hi, I would like to work on this bug. Though, I don't know where to start.

Comment 8

[Marco Zehe (:MarcoZ)]

I would start from the patch already there.

Alex, do you remember what your nit/comment was about that patch? Was it requiring a bigger change? I know it's been a long time ago...

Comment 9

[alexander :surkov (:asurkov)]

(In reply to Marco Zehe (:MarcoZ) from comment #8)
> I would start from the patch already there.
> 
> Alex, do you remember what your nit/comment was about that patch? Was it
> requiring a bigger change? I know it's been a long time ago...

no, just replacing role TABLE on APPLICATION, that's it

Comment 10

[Saurabh Singhal [:saurabhs]]

I don't know were to get the code to work on. Can you point me in the right direction?

Comment 11

[Mike Hoye [:mhoye]]

Hi, Saurabh - You can start here: http://areweeveryoneyet.org/onramp/desktop.html

to get setup to work on this code.

Comment 12

[Saurabh Singhal [:saurabhs]]

With the latest clone of mozilla-central repository, I can already see testRole("application_table", ROLE_APPLICATION); in accessible/tests/mochitest/role/test_aria.html file. Is there anything that needs to be done for this bug?