Open
Bug 739179
Opened 12 years ago
Updated 2 years ago
Provide test for strong table landmark "application" in test_aria_roles.html
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
NEW
People
(Reporter: capella, Unassigned, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(1 file)
876 bytes,
patch
|
surkov
:
review+
MarcoZ
:
feedback+
|
Details | Diff | Splinter Review |
Weak landmarks in test_aria_roles.html have _table tests in place. Strong landmark "Application" has orphaned _table definition with no test, possibly overlooked in Bug 469688.
Updated•12 years ago
|
Whiteboard: [good first bug][lang=js] → [good first bug][mentor=marco.zehe@googlemail.com][lang=js]
Comment 1•12 years ago
|
||
is it something like this? I tried running the test using the command TEST_PATH=accessible/tests/mochitest/test_aria_roles.html make -C $(OBJDIR) mochitest-plain but got an error saying "404 Not Found." How can I check if what I added into the source file is correct?
Attachment #612107 -
Flags: feedback?(marco.zehe)
Comment 2•12 years ago
|
||
Comment on attachment 612107 [details] [diff] [review] patch Yes, this is the right function call. However I'm not sure I understand what you're trying to call here on the command line. The tes harness is a chrome test harness, so mochitest-plain may just be the wrong argument here.
Attachment #612107 -
Flags: feedback?(marco.zehe) → feedback+
Updated•12 years ago
|
Assignee: nobody → pookveeraya
Comment 3•12 years ago
|
||
Comment on attachment 612107 [details] [diff] [review] patch Review of attachment 612107 [details] [diff] [review]: ----------------------------------------------------------------- r=me with comment fixed ::: accessible/tests/mochitest/test_aria_roles.html @@ +35,5 @@ > > // strong landmark > testRole("application", ROLE_APPLICATION); > testRole("form", ROLE_FORM); > + testRole("application_table", ROLE_TABLE); nah, it's strong landmark, I think it should be exposed as ROLE_APPLICATION
Updated•12 years ago
|
Attachment #612107 -
Flags: review+
Comment 4•12 years ago
|
||
(In reply to Veeraya Pupatwibul from comment #1) > Created attachment 612107 [details] [diff] [review] > patch > > is it something like this? I tried running the test using the command > TEST_PATH=accessible/tests/mochitest/test_aria_roles.html make -C $(OBJDIR) > mochitest-plain > but got an error saying "404 Not Found." > How can I check if what I added into the source file is correct? I use another way to start a11y mochitest: cd yourobjdir/_tests/testing/mochitest; python runtests.py --a11y --test-path=accessible/test_aria_roles.html
Comment 5•11 years ago
|
||
Can you confirm that you're still working on this bug?
Flags: needinfo?(pookveeraya)
Comment 6•10 years ago
|
||
Been a long time here - deassigning, throwing back in the pool.
Assignee: pookveeraya → nobody
Flags: needinfo?(pookveeraya)
Assignee | ||
Updated•10 years ago
|
Mentor: marco.zehe
Whiteboard: [good first bug][mentor=marco.zehe@googlemail.com][lang=js] → [good first bug][lang=js]
Comment 7•8 years ago
|
||
Hi, I would like to work on this bug. Though, I don't know where to start.
Flags: needinfo?(mzehe)
Comment 8•8 years ago
|
||
I would start from the patch already there. Alex, do you remember what your nit/comment was about that patch? Was it requiring a bigger change? I know it's been a long time ago...
Flags: needinfo?(mzehe) → needinfo?(surkov.alexander)
Comment 9•8 years ago
|
||
(In reply to Marco Zehe (:MarcoZ) from comment #8) > I would start from the patch already there. > > Alex, do you remember what your nit/comment was about that patch? Was it > requiring a bigger change? I know it's been a long time ago... no, just replacing role TABLE on APPLICATION, that's it
Flags: needinfo?(surkov.alexander)
Comment 10•8 years ago
|
||
I don't know were to get the code to work on. Can you point me in the right direction?
Comment 11•8 years ago
|
||
Hi, Saurabh - You can start here: http://areweeveryoneyet.org/onramp/desktop.html to get setup to work on this code.
Comment 12•8 years ago
|
||
With the latest clone of mozilla-central repository, I can already see testRole("application_table", ROLE_APPLICATION); in accessible/tests/mochitest/role/test_aria.html file. Is there anything that needs to be done for this bug?
Updated•4 years ago
|
Keywords: good-first-bug
Whiteboard: [good first bug][lang=js] → [lang=js]
Updated•2 years ago
|
Severity: minor → S4
You need to log in
before you can comment on or make changes to this bug.
Description
•