nsTextEquivUtils::AppendTextEquivFromContent shouldn't use GetAccService()->GetAccessible

RESOLVED FIXED in mozilla14

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: maxli)

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=hub@mozilla.com][lang=c++])

Attachments

(1 attachment, 1 obsolete attachment)

1.66 KB, patch
hub
: review+
tbsaunde
: review+
Details | Diff | Splinter Review
(Reporter)

Description

5 years ago
Do gInitiatorAcc->Document()->GetAccessible(aContent) instead (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsTextEquivUtils.cpp#139)

We never cross document boundaries in name calculation handled in nsTextEquivUtils so we can do that.
(Assignee)

Comment 1

5 years ago
Created attachment 610849 [details] [diff] [review]
patch v1

All mochitests pass; it compiles fine. I don't know if there's any other way for me to verify I made the right change...
Attachment #610849 - Flags: review?(hub)
you've removed the only meaningful use of shell so while your here you could stop getting the presShell all together.
Comment on attachment 610849 [details] [diff] [review]
patch v1

Review of attachment 610849 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsTextEquivUtils.cpp
@@ +135,5 @@
>    bool goThroughDOMSubtree = true;
>  
>    if (isVisible) {
>      nsAccessible* accessible =
> +      gInitiatorAcc->Document()->GetAccessible(aContent);

As Trevor said, please remove nsIPresShell line 121 since we don't use it anymore.
Attachment #610849 - Flags: review?(hub) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 611095 [details] [diff] [review]
Patch v2
Attachment #610849 - Attachment is obsolete: true
Attachment #611095 - Flags: review?(hub)
Comment on attachment 611095 [details] [diff] [review]
Patch v2

looks good thanks!
Attachment #611095 - Flags: review+
Comment on attachment 611095 [details] [diff] [review]
Patch v2

Review of attachment 611095 [details] [diff] [review]:
-----------------------------------------------------------------

looks good
Attachment #611095 - Flags: review?(hub) → review+
(Reporter)

Updated

5 years ago
Assignee: nobody → maxli
(Reporter)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8869f7a21a63
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/8869f7a21a63
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.