739193 - nsTextEquivUtils::AppendTextEquivFromContent shouldn't use GetAccService()->GetAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Do gInitiatorAcc->Document()->GetAccessible(aContent) instead (http://mxr.mozilla.org/mozilla-central/source/accessible/src/base/nsTextEquivUtils.cpp#139)

We never cross document boundaries in name calculation handled in nsTextEquivUtils so we can do that.

Comment 1

[Max Li [:maxli]]

Attachment: patch v1

All mochitests pass; it compiles fine. I don't know if there's any other way for me to verify I made the right change...

Comment 2

[Trevor Saunders (:tbsaunde)]

you've removed the only meaningful use of shell so while your here you could stop getting the presShell all together.

Comment 3

[Hubert Figuiere [:hub]]

Comment on attachment 610849 [details] [diff] [review]
patch v1

Review of attachment 610849 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/base/nsTextEquivUtils.cpp
@@ +135,5 @@
>    bool goThroughDOMSubtree = true;
>  
>    if (isVisible) {
>      nsAccessible* accessible =
> +      gInitiatorAcc->Document()->GetAccessible(aContent);

As Trevor said, please remove nsIPresShell line 121 since we don't use it anymore.

Comment 4

[Max Li [:maxli]]

Attachment: Patch v2

Comment 5

[Trevor Saunders (:tbsaunde)]

Comment on attachment 611095 [details] [diff] [review]
Patch v2

looks good thanks!

Comment 6

[Hubert Figuiere [:hub]]

Comment on attachment 611095 [details] [diff] [review]
Patch v2

Review of attachment 611095 [details] [diff] [review]:
-----------------------------------------------------------------

looks good

Comment 7

[alexander :surkov (:asurkov)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8869f7a21a63

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/8869f7a21a63