739256 - Graphical polish for first-run profile import experience

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Gian-Carlo Pascutto [:gcp]]

+++ This bug was initially created as a clone of Bug #729532 +++

Bug 729532 had some problems with getting the "fake" tab bar right - on my phone it is cut in half. Sriram also had a go on it, but his patch doesn't work either. We don't want to block the string changes on the graphical polish any longer.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

The mockup:

https://bugzilla.mozilla.org/attachment.cgi?id=605044

I don't think we want to block on this.If we get it done... great. Right now the UI is done, except for the little curve in the fake toolbar.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

FYI, the problem was visible on my Samsung Galaxy S2, running Android 2.3.6.

Comment 3

[Ian Barlow (:ibarlow)]

If we don't land this right away, can we at least leave the tab curve out until we fix it? I'd rather us use a blank blue screen than one where the tab image is cut off. 

Thx :)

Comment 4

[Gian-Carlo Pascutto [:gcp]]

It's already like that. I didn't land the (problematic) part containing the tab curve, only the new colors & text.

Comment 5

[Ian Barlow (:ibarlow)]

Ah awesome thanks :)

Comment 6

[Sriram Ramasubramanian [:sriram]]

Seriously? Why Galaxy S2 why? In fact.. Why Samsung? Why?

The problem is, the code tries to hide the top "notification bar". This works with Galaxy Nexus, Nexus S. But not with Samsung S2 (basically it is overlaid on top). This makes it feel like the tab button is cut off. If we change the code "not to hide" the title bar, we should be good. My patch from old bug works fine.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

Ian - Is this still needed? I think we went a different direction and we can close this as WONTFIX.

Comment 8

[Ian Barlow (:ibarlow)]

works for me.