739287 - Table cells too close on diff view and cells too close

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect, P1)

Description

[Peter Bengtsson [:peterbe]]

The horizontal table cells are too close to each other. 
http://cl.ly/281S0l3u2g2W2P153V3K

Also, the left-most part of the word appears more to the left than its parent.

Comment 1

[Peter Bengtsson [:peterbe]]

:Pike what do you think of this? 
http://cl.ly/410Z0V3B3C3z2d2E2s1W

Comment 3

[Axel Hecht [:Pike]]

If the file contents would be a bit more indented, that'd be nice.

Also, it'd help to see an actual change of files to talk about the spacing.

Comment 4

[Peter Bengtsson [:peterbe]]

Attachment: nice looking diff view

Final result is this http://cl.ly/2P0Z3R2Z0U0d1g0Z3r3w

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 609716 [details] [diff] [review]
nice looking diff view

Review of attachment 609716 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the nit below.

::: apps/shipping/static/shipping/css/diff.css
@@ +65,5 @@
> +table.diff {
> +  margin-left: 20px;
> +}
> +table.diff td {
> +  vertical-align:top;

nit, ' ' after the :

Comment 6

[Peter Bengtsson [:peterbe]]

landed https://github.com/mozilla/elmo/commit/4f042273b29c070520b04f427dbb53575886bbb5