739350 - Door-hanger directional arrow is low resolution

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/26) - Door-hanger

Look at them pixels.

--
Galaxy Nexus (Android 4.0.2)
Nightly (03/26)
Mozilla/5.0 (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0a1

Comment 1

[Aaron Train [:aaronmt]]

What say you, UX?

Comment 2

[Ian Barlow (:ibarlow)]

Yep, that looks pretty busted. 

I believe we have provided multiple resolutions for this, so I wonder if we're using the wrong asset. 

Adding Sriram, our resident multi resolution asset expert.

Comment 3

[Sriram Ramasubramanian [:sriram]]

We have not supplied the xhdpi resources. :sigh:
That will fix the issue.

Comment 4

[Ian Barlow (:ibarlow)]

Attachment: graphic assets

Here you go sriram

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

This should be a simple addition of an image. Low risk and will make us look better on ICS

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Do we need the other doorhanger_*.png assests too?

http://mxr.mozilla.org/mozilla-central/find?text=&string=doorhanger_

Comment 7

[Sriram Ramasubramanian [:sriram]]

Actually the doorhanger_*.* is same in drawable/ and drawable-hdpi/
We need resources for both drawable-hdpi/ and drawable-xhdpi-v11/

Comment 8

[Ian Barlow (:ibarlow)]

Bugzilla is not letting me upload this zip file of assets, so here's a link http://cl.ly/10330b1x3a2g3F2c1e20

That includes all the doorhanger bits, across mdpi / hdpi / xhdpi. Sriram, let me know how these work out.

Comment 9

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patch replaces the doorhanger resources for hdpi and xhdpi.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 617538 [details] [diff] [review]
Patch

Looks good. Cleared for landing.

Comment 11

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/33c843f70204

Comment 12

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/33c843f70204

Comment 13

[Paul Feher]

The issue is not reproducible anymore on:
Nightly Fennec 15.0a1 (2012-05-27)
Aurora Fennec 14.0a2 (2012-05-27)
Device: HTC Desire Z (2.3.3), Galaxy Nexus (4.0.2)