739446 - Default AMO bookmark should point to android native addons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Wesley Johnston (:wesj)]

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/strings.xml.in#142


https://addons.mozilla.org/@AB_CD@/mobile/
should be
https://addons.mozilla.org/@AB_CD@/android/

Does SUMO want/need a similar tweak or are we ok there?

Comment 1

[Wesley Johnston (:wesj)]

CC'ing michelle so that the can tell us what Sumo wants.

While we're at it, the default favicon we have for SUMO doesn't match what SUMO has on their site (a 16px Firefox icon). It would be nice if all of our sites used high res favicons for us (I think there's a bug for that), but we can update to something here if you want as well.

I hate all our default bookmarks having the same favicon as well, so I'm kinda torn about what to do there (which is why I left in the old one!).

You guys have any preferences about what we use?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

This patch fixes the AMO link

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 615480 [details] [diff] [review]
patch

Sorry 'bout that :(

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a76755f58bbb

Comment 5

[Wesley Johnston (:wesj)]

Attachment: Test fix

I think this will fix some test failures. Haven't tried it yet (my tree is in a... special state).

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 615592 [details] [diff] [review]
Test fix

Bah. Shameful that I missed this.

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/793b37be1953

Comment 8

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/793b37be1953

Comment 9

[Cristian Nicolae (:xti)]

This issue is fixed on the latest Nightly build. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-23)
Device: Galaxy Nexus
OS: Android 4.0.2