Closed
Bug 739510
Opened 14 years ago
Closed 14 years ago
Speed up construction of char * properties
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jrmuizel, Assigned: jrmuizel)
Details
Attachments
(1 file)
|
1.01 KB,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
This eliminates two additional copies: NS_ConvertASCIItoUTF16 and PromiseFlatString by constructing the JSString directly. It is also designed
so that literal strings will have their strlen computed at compile time.
|
Assignee | |
Comment 1•14 years ago
|
||
Assignee: nobody → jmuizelaar
Attachment #609594 -
Flags: review?
|
||
Comment 2•14 years ago
|
||
Comment on attachment 609594 [details] [diff] [review]
Speed up DefineProperty for const char *
Review of attachment 609594 [details] [diff] [review]:
-----------------------------------------------------------------
::: tools/profiler/JSObjectBuilder.h
@@ +93,5 @@
> + if (!string)
> + mOk = JS_FALSE;
> +
> + if (!mOk)
> + return;
if (!string) {
mOk = JS_FALSE;
return;
}
Attachment #609594 -
Flags: review? → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
|
||
Comment 5•14 years ago
|
||
(In reply to Jeff Muizelaar [:jrmuizel] from comment #0)
> It is also designed
> so that literal strings will have their strlen computed at compile time.
How so?
You need to log in
before you can comment on or make changes to this bug.
Description
•