Last Comment Bug 739520 - rm JSOP_SETLOCALPOP
: rm JSOP_SETLOCALPOP
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: ARM All
: -- normal (vote)
: mozilla14
Assigned To: Luke Wagner [:luke]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-26 22:33 PDT by Luke Wagner [:luke]
Modified: 2012-03-29 08:48 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
rm (13.74 KB, patch)
2012-03-26 22:33 PDT, Luke Wagner [:luke]
bhackett1024: review+
Details | Diff | Splinter Review

Description Luke Wagner [:luke] 2012-03-26 22:33:10 PDT
Created attachment 609620 [details] [diff] [review]
rm

setlocalpop complicates bug 659577.  It is only emitted in two cases: in catch blocks and the lhs of a destructuring assignment/initialization so it's not winning us anything in size.  Simple removal patch.
Comment 1 Luke Wagner [:luke] 2012-03-27 21:26:39 PDT
(green on try)
Comment 3 Marco Bonardo [::mak] (Away 6-20 Aug) 2012-03-29 08:48:42 PDT
https://hg.mozilla.org/mozilla-central/rev/e44e3729a052

Note You need to log in before you can comment on or make changes to this bug.