739531 - Can't duplicate a tab with designMode and no body

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[Paul Silaghi, QA [:pauly]]

STR:
1. Open https://bug713417.bugzilla.mozilla.org/attachment.cgi?id=584240
2. Try to duplicate the tab (hold CTRL key and drag the tab to the right)

Actual results:
Nothing happens

Expected results:
The tab should duplicate

Note:
Reproducible on FF 14 (2012-03-26) on all platforms

Comment 1

[Jesse Ruderman]

The error console shows:

Error: uncaught exception: [Exception... "'[JavaScript Error: "aContent.document.body is null" {file: "resource:///components/nsSessionStore.js" line: 2176}]' when calling method: [nsISessionStore::duplicateTab]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "JS frame :: chrome://browser/content/tabbrowser.xml :: duplicateTab :: line 2189"  data: yes]

http://hg.mozilla.org/mozilla-central/annotate/a30fd69f1e0c/browser/components/sessionstore/src/nsSessionStore.js#l2193 assumes the document has a body element, and throws when the assumption doesn't hold.

(To reproduce on Mac, hold Option rather than Ctrl.)

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.1

This does the trick. I covered both ends - saving & restoring - in case we do save data & try to restore into a document we no longer can.

Comment 3

[Dietrich Ayala (:dietrich)]

Comment on attachment 609890 [details] [diff] [review]
Patch v0.1

Review of attachment 609890 [details] [diff] [review]:
-----------------------------------------------------------------

looks good. should be easily testable, will r+ with that.

Comment 4

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

Attachment: Patch v0.2

Cleaning out my assigned bugs and this was easy enough to finish up.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/integration/fx-team/rev/41fdd17ee9d3

Comment 6

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/mozilla-central/rev/41fdd17ee9d3

Comment 7

[Paul Silaghi, QA [:pauly]]

Duplication works ok now. Verified fixed on FF 15.0a1 (2012-05-27) on Win 7, Ubuntu 12.04 and Mac OS X 10.6.