739574 - Set the tabsontop attribute on the navigation toolbar and simplify CSS selectors

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

Attachment: patch

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 609686 [details] [diff] [review]
patch

Review of attachment 609686 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/winstripe/browser.css
@@ +1001,5 @@
>  }
>  
>  %ifdef WINSTRIPE_AERO
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > #tabview-button:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > toolbarpaletteitem > #tabview-button:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),

There's something extra being added here in the toolbarpaletteitem case, right? Previosly it would only match with TabsToolbar as parent. Is this intentional?

@@ +2049,5 @@
>  }
>  
>  %ifdef WINSTRIPE_AERO
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > #alltabs-button[type=menu]:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > toolbarpaletteitem > #alltabs-button[type=menu]:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),

same

Comment 2

[Dão Gottwald [:dao]]

> There's something extra being added here in the toolbarpaletteitem case,
> right? Previosly it would only match with TabsToolbar as parent. Is this
> intentional?

I'm replacing descendant selectors with child selectors explicitly covering toolbarpaletteitem, which performs better.

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/mozilla-central/rev/d045d693568a