Last Comment Bug 739574 - Set the tabsontop attribute on the navigation toolbar and simplify CSS selectors
: Set the tabsontop attribute on the navigation toolbar and simplify CSS selectors
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Theme (show other bugs)
: Trunk
: All Windows 7
: -- normal (vote)
: Firefox 14
Assigned To: Dão Gottwald [:dao]
:
: Dão Gottwald [:dao]
Mentors:
Depends on:
Blocks: 745757
  Show dependency treegraph
 
Reported: 2012-03-27 05:41 PDT by Dão Gottwald [:dao]
Modified: 2012-04-16 08:29 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (10.11 KB, patch)
2012-03-27 05:41 PDT, Dão Gottwald [:dao]
felipc: review+
Details | Diff | Splinter Review

Description Dão Gottwald [:dao] 2012-03-27 05:41:38 PDT
Created attachment 609686 [details] [diff] [review]
patch
Comment 1 :Felipe Gomes (needinfo me!) 2012-03-29 02:23:11 PDT
Comment on attachment 609686 [details] [diff] [review]
patch

Review of attachment 609686 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/winstripe/browser.css
@@ +1001,5 @@
>  }
>  
>  %ifdef WINSTRIPE_AERO
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > #tabview-button:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > toolbarpaletteitem > #tabview-button:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),

There's something extra being added here in the toolbarpaletteitem case, right? Previosly it would only match with TabsToolbar as parent. Is this intentional?

@@ +2049,5 @@
>  }
>  
>  %ifdef WINSTRIPE_AERO
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > #alltabs-button[type=menu]:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > toolbarpaletteitem > #alltabs-button[type=menu]:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),

same
Comment 2 Dão Gottwald [:dao] 2012-03-29 02:31:14 PDT
> There's something extra being added here in the toolbarpaletteitem case,
> right? Previosly it would only match with TabsToolbar as parent. Is this
> intentional?

I'm replacing descendant selectors with child selectors explicitly covering toolbarpaletteitem, which performs better.
Comment 3 Dão Gottwald [:dao] 2012-03-29 03:32:10 PDT
https://hg.mozilla.org/mozilla-central/rev/d045d693568a

Note You need to log in before you can comment on or make changes to this bug.