Closed Bug 739574 Opened 8 years ago Closed 8 years ago

Set the tabsontop attribute on the navigation toolbar and simplify CSS selectors

Categories

(Firefox :: Theme, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
No description provided.
Attachment #609686 - Flags: review?(felipc)
Comment on attachment 609686 [details] [diff] [review]
patch

Review of attachment 609686 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/winstripe/browser.css
@@ +1001,5 @@
>  }
>  
>  %ifdef WINSTRIPE_AERO
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > #tabview-button:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > toolbarpaletteitem > #tabview-button:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),

There's something extra being added here in the toolbarpaletteitem case, right? Previosly it would only match with TabsToolbar as parent. Is this intentional?

@@ +2049,5 @@
>  }
>  
>  %ifdef WINSTRIPE_AERO
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > #alltabs-button[type=menu]:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),
> +:-moz-any(#TabsToolbar, #nav-bar[tabsontop=false], #toolbar-menubar) > toolbarpaletteitem > #alltabs-button[type=menu]:-moz-system-metric(windows-compositor):not(:-moz-lwtheme),

same
Attachment #609686 - Flags: review?(felipc) → review+
> There's something extra being added here in the toolbarpaletteitem case,
> right? Previosly it would only match with TabsToolbar as parent. Is this
> intentional?

I'm replacing descendant selectors with child selectors explicitly covering toolbarpaletteitem, which performs better.
https://hg.mozilla.org/mozilla-central/rev/d045d693568a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Blocks: 745757
You need to log in before you can comment on or make changes to this bug.