739601 - Replace config/milestone.pl

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Joey Armstrong [:joey]]

Port config/milestone.pl to python and write unit a unit test for the script.
   - the .pl script will also generate an uninit var warning when called w/o --topsrcdir.

toolkit/xre/Makefile.in - this makefile is setup to read milestone.txt in different ways {stale code?}.  Calling milestone.pl and cat config/milestone.txt.  Cat should be replaced by a call to the script so whitespace and embedded newlines cannot affect extracting a value from the file.

Comment 1

[(not currently active) Ted Mielczarek]

I'm not sure why we read the file in two ways, but it may be that certain locations actually want the full version number there. milestone.pl simply strips off the trailing bits (like "a1"), which seems like hugely overkill at this point. Perhaps it did more in an ancient time, I can't remember.

Comment 2

[Mike Hommey [:glandium]]

It probably made sense when we had versions like x.ya1pre.

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://tbpl.mozilla.org/?tree=Try&rev=0320fa8e7694

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://tbpl.mozilla.org/?tree=Try&rev=5bac7760384b

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Rewrite (the used parts of) config/milestone.pl in python

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8542902 [details] [diff] [review]
Rewrite (the used parts of) config/milestone.pl in python

Review of attachment 8542902 [details] [diff] [review]:
-----------------------------------------------------------------

Most excellent.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b33fc49396c

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b33fc49396c