739629 - Expose safe account creation API for profile migration

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P1)

Description

[Richard Newman [:rnewman]]

+++ This bug was initially created as a clone of Bug #734211 +++

This will largely entail lifting AccountActivity.createAccount and adding validation, and documenting its assumptions (e.g., about threading).

Also will need an option to ensure that no account already exists, to avoid ending up with two!

**DONE**: While we're here, we can also add a little API to check whether a Sync account exists, and strip that logic out of the main Fennec code.

Comment 1

[Damon Sicore (:damons)]

This sounds like scope creep pre-1.0 release.  I see this isn't marked as a blocker.  Are we being careful not to add more features this late in the game?

Comment 2

[Richard Newman [:rnewman]]

(In reply to Damon Sicore (:damons) from comment #1)
> This sounds like scope creep pre-1.0 release.  I see this isn't marked as a
> blocker.

It blocks a blocker: Bug 715550.

> Are we being careful not to add more features this late in the
> game?

Broadly, yes. Bug 715550 is a long-standing feature item. This bug is only so much younger because it was forked off Bug 734211 to avoid multi-part nonsense.

Without this bug, a XUL Fennec user with Sync set up will lose their Sync settings. With this bug (and Bug 715550, of course) they'll be silently migrated to Android Sync and receive continuity of service.

If that's considered too risky or schedule-affecting for Beta, then please re-triage Bug 715550, and we'll adjust the priority for this accordingly.

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Delaying bugs related to profile migration past beta means they will be released with essentially 0 testing. Delaying them past release is effectively WONTFIX-ing them.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

What is the status here? Can we get someone assigned to work on this bug?

Comment 5

[Richard Newman [:rnewman]]

See https://bugzilla.mozilla.org/show_bug.cgi?id=715550#c2 for details.

Comment 6

[Richard Newman [:rnewman]]

First draft review done. Waiting on review changes to reflect migration of client ID/name as well as account details.

Comment 7

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla-services/android-sync/pull/157

Comment 8

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/190a237b1456

See 

<https://bugzilla.mozilla.org/show_bug.cgi?id=715550#c10>

or

<https://github.com/mozilla-services/android-sync/blob/develop/test/src/org/mozilla/gecko/sync/setup/test/TestSyncAccounts.java#L193>

for suggested usage.

Comment 9

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/190a237b1456