Order of ColorLayers is reversed every paint

RESOLVED FIXED in mozilla17

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

Tracking

Trunk
mozilla17
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Posted patch Reverse ImageLayer ordering (obsolete) — Splinter Review
When we have multiple ColorLayers within a single container, their order is reversed every paint.

I believe this is because we process ThebesLayers in a stack, so we should be retrieving the ColorLayers (and ImageLayers) in reverse order.
Attachment #609753 - Flags: review?(roc)
Turns out that the original approach didn't actually work. The ordering isn't consistent at all, and reversing the order broke as many tests as it fixed.
Attachment #609753 - Attachment is obsolete: true
Attachment #618538 - Flags: review?(roc)
CC'ing nrc since this may affect his MaskLayer patches
Comment on attachment 618538 [details] [diff] [review]
Attach ImageLayers to the ThebesLayer it replaces

Review of attachment 618538 [details] [diff] [review]:
-----------------------------------------------------------------

Good plan
Attachment #618538 - Flags: review?(roc) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/d80219c8842c
Assignee: nobody → matt.woodrow
Target Milestone: --- → mozilla15
Version: unspecified → Trunk
Ok, so this is pretty sad faces, but I've had to back this out for causing mochitest-4 permaorange (as well as the talos regressions in comment 237):
https://tbpl.mozilla.org/?tree=Mozilla-Inbound&rev=61fd66629c4f

eg https://tbpl.mozilla.org/php/getParsedLog.php?id=12544443&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/f08886a8cf22

It's for times like these that a relanding script would be pretty useful, for automating the qimport of a lange range of changesets (or at least it would make me feel less bad about having to back things like this out). 

Sorry! :-(
Target Milestone: mozilla15 → ---
https://hg.mozilla.org/mozilla-central/rev/90ab708bab8b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
This got backed out with the rest of 539356 initially.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc76f965c041
Assignee: matt.woodrow → nobody
Status: RESOLVED → REOPENED
Component: Layout → Keyboard: Navigation
Resolution: FIXED → ---
Target Milestone: mozilla16 → mozilla15
Version: Trunk → Other Branch
Assignee: nobody → matt.woodrow
Component: Keyboard: Navigation → Layout
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: mozilla15 → ---
Version: Other Branch → Trunk
https://hg.mozilla.org/mozilla-central/rev/bc76f965c041
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.