Note: There are a few cases of duplicates in user autocompletion which are being worked on.

onsettingchange is not called when the setting is changed inside another window

RESOLVED FIXED

Status

()

Core
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vingtetun, Assigned: vingtetun)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Created attachment 609764 [details] [diff] [review]
Patch

In Gaia onsettingchange is not called on the homescreen (or every other windows) when there is a change in the settings application.
Attachment #609764 - Flags: review?(fabrice)
Comment on attachment 609764 [details] [diff] [review]
Patch

Review of attachment 609764 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/settings/SettingsManager.js
@@ +4,5 @@
>  
>  "use strict"
>  
>  /* static functions */
> +let DEBUG = 1;

nit: set to 0 before pushing

@@ +166,5 @@
> +              lock._open = true;
> +
> +              Services.DOMRequest.fireSuccess(request, 0);
> +
> +              dump('\n\n\n\n\n\n------------------------------ FIRE for: ' + key +'\n');

idem
Attachment #609764 - Flags: review?(fabrice) → review+
Created attachment 609817 [details] [diff] [review]
Patch for check-in
https://hg.mozilla.org/mozilla-central/rev/aa0f1e5fcf00
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.