Closed
Bug 739680
Opened 13 years ago
Closed 13 years ago
onsettingchange is not called when the setting is changed inside another window
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
People
(Reporter: vingtetun, Assigned: vingtetun)
References
Details
Attachments
(2 files)
|
5.94 KB,
patch
|
fabrice
:
review+
|
Details | Diff | Splinter Review |
|
5.39 KB,
patch
|
Details | Diff | Splinter Review |
In Gaia onsettingchange is not called on the homescreen (or every other windows) when there is a change in the settings application.
Attachment #609764 -
Flags: review?(fabrice)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 609764 [details] [diff] [review]
Patch
Review of attachment 609764 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/settings/SettingsManager.js
@@ +4,5 @@
>
> "use strict"
>
> /* static functions */
> +let DEBUG = 1;
nit: set to 0 before pushing
@@ +166,5 @@
> + lock._open = true;
> +
> + Services.DOMRequest.fireSuccess(request, 0);
> +
> + dump('\n\n\n\n\n\n------------------------------ FIRE for: ' + key +'\n');
idem
Attachment #609764 -
Flags: review?(fabrice) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
|
|
||
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•