Last Comment Bug 739680 - onsettingchange is not called when the setting is changed inside another window
: onsettingchange is not called when the setting is changed inside another window
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
:
:
Mentors:
Depends on:
Blocks: 678695
  Show dependency treegraph
 
Reported: 2012-03-27 10:07 PDT by Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
Modified: 2012-03-27 12:07 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (5.94 KB, patch)
2012-03-27 10:07 PDT, Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
fabrice: review+
Details | Diff | Splinter Review
Patch for check-in (5.39 KB, patch)
2012-03-27 11:41 PDT, Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)
no flags Details | Diff | Splinter Review

Description Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-03-27 10:07:38 PDT
Created attachment 609764 [details] [diff] [review]
Patch

In Gaia onsettingchange is not called on the homescreen (or every other windows) when there is a change in the settings application.
Comment 1 [:fabrice] Fabrice Desré 2012-03-27 10:21:42 PDT
Comment on attachment 609764 [details] [diff] [review]
Patch

Review of attachment 609764 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/settings/SettingsManager.js
@@ +4,5 @@
>  
>  "use strict"
>  
>  /* static functions */
> +let DEBUG = 1;

nit: set to 0 before pushing

@@ +166,5 @@
> +              lock._open = true;
> +
> +              Services.DOMRequest.fireSuccess(request, 0);
> +
> +              dump('\n\n\n\n\n\n------------------------------ FIRE for: ' + key +'\n');

idem
Comment 2 Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) 2012-03-27 11:41:03 PDT
Created attachment 609817 [details] [diff] [review]
Patch for check-in
Comment 3 [:fabrice] Fabrice Desré 2012-03-27 12:07:19 PDT
https://hg.mozilla.org/mozilla-central/rev/aa0f1e5fcf00

Note You need to log in before you can comment on or make changes to this bug.