739680 - onsettingchange is not called when the setting is changed inside another window

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

In Gaia onsettingchange is not called on the homescreen (or every other windows) when there is a change in the settings application.

Comment 1

[[:fabrice] Fabrice Desré]

Comment on attachment 609764 [details] [diff] [review]
Patch

Review of attachment 609764 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/settings/SettingsManager.js
@@ +4,5 @@
>  
>  "use strict"
>  
>  /* static functions */
> +let DEBUG = 1;

nit: set to 0 before pushing

@@ +166,5 @@
> +              lock._open = true;
> +
> +              Services.DOMRequest.fireSuccess(request, 0);
> +
> +              dump('\n\n\n\n\n\n------------------------------ FIRE for: ' + key +'\n');

idem

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch for check-in

Comment 3

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/mozilla-central/rev/aa0f1e5fcf00