gfxFont.cpp compiler warnings on OSX

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jtd, Assigned: jtd)

Tracking

Trunk
mozilla14
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Under OSX, gfxFont.cpp generates compile warnings:

/builds/mozcentral/gfx/thebes/gfxFont.cpp: In member function ‘bool gfxFont::SplitAndInitTextRun(gfxContext*, gfxTextRun*, const T*, PRUint32, PRUint32, PRInt32) [with T = PRUint8]’:
/builds/mozcentral/gfx/thebes/gfxFont.cpp:3381:   instantiated from ‘void gfxFontGroup::InitScriptRun(gfxContext*, gfxTextRun*, const T*, PRUint32, PRUint32, PRInt32) [with T = PRUint8]’
/builds/mozcentral/gfx/thebes/gfxFont.cpp:3282:   instantiated from ‘void gfxFontGroup::InitTextRun(gfxContext*, gfxTextRun*, const T*, PRUint32) [with T = PRUint8]’
/builds/mozcentral/gfx/thebes/gfxFont.cpp:3206:   instantiated from here
/builds/mozcentral/gfx/thebes/gfxFont.cpp:2216: warning: comparison is always false due to limited range of data type
/builds/mozcentral/gfx/thebes/gfxFont.cpp:2294: warning: comparison is always true due to limited range of data type
(Assignee)

Comment 1

6 years ago
Created attachment 609804 [details] [diff] [review]
patch, fix warnings
Attachment #609804 - Flags: review?(jfkthame)
Comment on attachment 609804 [details] [diff] [review]
patch, fix warnings

Review of attachment 609804 [details] [diff] [review]:
-----------------------------------------------------------------

Seems fine.
Attachment #609804 - Flags: review?(jfkthame) → review+
(Assignee)

Comment 3

6 years ago
Pushed to inbound
https://hg.mozilla.org/integration/mozilla-inbound/rev/7cf8fc503806

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/7cf8fc503806
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.