Last Comment Bug 739760 - doubles and floats can't be used in dictionaries
: doubles and floats can't be used in dictionaries
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPConnect (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Doug Turner (:dougt)
:
Mentors:
Depends on:
Blocks: 719320 721569
  Show dependency treegraph
 
Reported: 2012-03-27 13:11 PDT by Olli Pettay [:smaug] (vacation Aug 25-28)
Modified: 2012-03-29 08:40 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch v.1 (1.55 KB, patch)
2012-03-27 15:16 PDT, Doug Turner (:dougt)
khuey: review+
Details | Diff | Splinter Review

Description Olli Pettay [:smaug] (vacation Aug 25-28) 2012-03-27 13:11:34 PDT
This is rather major regression
Comment 1 Doug Turner (:dougt) 2012-03-27 15:16:42 PDT
Created attachment 609910 [details] [diff] [review]
patch v.1
Comment 2 Masatoshi Kimura [:emk] 2012-03-27 18:40:11 PDT
Are there any actual use cases for float? (assuming that WheelEventInit will be changed)
Comment 3 Olli Pettay [:smaug] (vacation Aug 25-28) 2012-03-27 21:46:02 PDT
Probably not, but there is also no reason to not-support it.
Comment 4 Jonas Sicking (:sicking) No longer reading bugmail consistently 2012-03-27 23:07:36 PDT
You should probably add an explicit cast when casting from 'double' to 'float' to avoid compile-time warnings about loss of precision.
Comment 5 Matt Brubeck (:mbrubeck) 2012-03-29 08:40:38 PDT
https://hg.mozilla.org/mozilla-central/rev/f2a1b3b8f3ce

Note You need to log in before you can comment on or make changes to this bug.