Make nsDOMEventTarget subclasses inherit from nsDOMEventTargetHelper first

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Device Interfaces
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: khuey, Assigned: mounir)

Tracking

unspecified
mozilla14
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Its very confusing to see things that inherit from nsDOMEventTargetHelper second or third and wonder about why that is safe.

Comment 1

5 years ago
What does not inherit from *Helper first ?
BluetoothDevice, BluetoothAdapter, SMSManager, SMSRequest
(Assignee)

Comment 3

5 years ago
Created attachment 610171 [details] [diff] [review]
Patch
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #610171 - Flags: review?(khuey)

Updated

5 years ago
Attachment #610171 - Flags: review?(khuey) → review+
(Assignee)

Updated

5 years ago
Attachment #610171 - Flags: checkin+
(Assignee)

Comment 4

5 years ago
Oups, I didn't realize you did the review Olli. I just pushed the patch to inbound with r=khuey...
(Assignee)

Updated

5 years ago
Flags: in-testsuite-
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/7b18a4980189
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.