Closed Bug 739898 Opened 12 years ago Closed 12 years ago

Stop using enablePrivilege in test_bug480509.html

Categories

(Core Graveyard :: Security: UI, defect)

Product:
Core Graveyard
Component:
Security: UI
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla14

People

(Reporter: peterv, Assigned: peterv)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

v1
2.07 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review
Attached patch v1 — — Splinter Review 
Stop using enablePrivilege, add an API to SpecialPowers to set a property to a value and use it to set xhr.channel.notificationsCallback.
Attachment #610020 - Flags: review?(bzbarsky)
Comment on attachment 610020 [details] [diff] [review]
v1

r=me.  I'm impressed there was no eval involved in the impl!  ;)
Attachment #610020 - Flags: review?(bzbarsky) → review+
Are you able to use |SpecialPowers.wrap(req).channel.notificationCallbacks = foo| instead?
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba46fc01fb32

I'll file a new bug to try the SpecialPowers.wrap method.
http://hg.mozilla.org/mozilla-central/rev/183eed448b9d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/ba46fc01fb32
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 12 years ago → 12 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.