Last Comment Bug 739898 - Stop using enablePrivilege in test_bug480509.html
: Stop using enablePrivilege in test_bug480509.html
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Security: UI (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Peter Van der Beken [:peterv]
:
Mentors:
Depends on:
Blocks: ParisBindings
  Show dependency treegraph
 
Reported: 2012-03-27 22:29 PDT by Peter Van der Beken [:peterv]
Modified: 2012-03-29 09:23 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (2.07 KB, patch)
2012-03-27 22:29 PDT, Peter Van der Beken [:peterv]
bzbarsky: review+
Details | Diff | Review

Description Peter Van der Beken [:peterv] 2012-03-27 22:29:29 PDT
Created attachment 610020 [details] [diff] [review]
v1

Stop using enablePrivilege, add an API to SpecialPowers to set a property to a value and use it to set xhr.channel.notificationsCallback.
Comment 1 Boris Zbarsky [:bz] 2012-03-27 22:49:28 PDT
Comment on attachment 610020 [details] [diff] [review]
v1

r=me.  I'm impressed there was no eval involved in the impl!  ;)
Comment 2 Josh Matthews [:jdm] 2012-03-28 01:18:22 PDT
Are you able to use |SpecialPowers.wrap(req).channel.notificationCallbacks = foo| instead?
Comment 3 Peter Van der Beken [:peterv] 2012-03-28 17:03:34 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba46fc01fb32

I'll file a new bug to try the SpecialPowers.wrap method.
Comment 4 Peter Van der Beken [:peterv] 2012-03-28 17:04:48 PDT
http://hg.mozilla.org/mozilla-central/rev/183eed448b9d
Comment 5 Marco Bonardo [::mak] 2012-03-29 08:54:15 PDT
https://hg.mozilla.org/mozilla-central/rev/ba46fc01fb32
Comment 6 Matt Brubeck (:mbrubeck) 2012-03-29 08:54:40 PDT
https://hg.mozilla.org/mozilla-central/rev/ba46fc01fb32

Note You need to log in before you can comment on or make changes to this bug.