Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Remove Firefox 2 UI migration code

RESOLVED FIXED in Firefox 14



5 years ago
5 years ago


(Reporter: dao, Assigned: dao)


Firefox 14

Firefox Tracking Flags

(Not tracked)



(1 attachment)



5 years ago
Created attachment 610039 [details] [diff] [review]

Time to let go...
Attachment #610039 - Flags: review?(dolske)
It looks like the negative effects to someone not hitting this code are that their back/forward buttons will disappear (but still be recoverable by customizing). That's seems fine given how likely there are to be any users hitting this path, I guess, but it also doesn't seem like such a huge burden to maintain given that we're doing other similar migration anyways.

Ideally I'd like to move this migrateUI code to it's own module, it doesn't really need to live in nsBrowserGlue.

I guess this also highlights the fact that it would be handy for future migration code auditing if we made sure to clearly label new migration paths with a comment indicating which Firefox version they're relevant to (the other blocks don't mention versions - easy enough to do the blame dance, but comments would be quicker).

Comment 2

5 years ago
This isn't covered by tests and nobody's actively making sure it keeps working as expected -- which is why this doesn't seem like a burden. This would be ok if only profiles upgrading from Firefox 2 hit this code. However, it runs in every new profile. So I really do think we should progressively get rid of the ancient migration paths.
Good point re: new profiles. To be clear, I wasn't really objecting to the removal, I was mostly just thinking out loud :)
Attachment #610039 - Flags: review?(dolske) → review+

Comment 4

5 years ago
Target Milestone: --- → Firefox 14
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.