browser/components/build fails to link on mingw

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Installer
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

unspecified
Firefox 14
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 610051 [details] [diff] [review]
fix v1.0

That's because GCC doesn't support #pragma comment(lib, ...) construct added in bug 491947. The fix is to use OS_LIBS the way all other imports do.
Attachment #610051 - Flags: review?(jmathies)

Updated

6 years ago
Attachment #610051 - Flags: review?(jmathies) → review+
(Assignee)

Comment 1

6 years ago
Thanks for the review:

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a45337b5ed6
Target Milestone: --- → Firefox 14

Comment 2

6 years ago
https://hg.mozilla.org/mozilla-central/rev/6a45337b5ed6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.