Closed Bug 739957 Opened 9 years ago Closed 9 years ago

More than 2 lines strings in .properties files are broken

Categories

(Add-on SDK Graveyard :: General, defect, P1)

x86_64
Windows 7
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ochameau, Assigned: ochameau)

Details

Attachments

(1 file)

In l10n .properties files, if you use similar valid .properties line:
key= some\
multiline\
string

It fails with an error during cfx run/xpi execution.
Attached file Pull request 390
Assignee: nobody → poirot.alex
Attachment #610102 - Flags: review?(warner-bugzilla)
Might be nice to have in 1.6 as it is a quite simple patch.
But not critical either as localization won't be massively used until HTML localization feature.
Comment on attachment 610102 [details]
Pull request 390

pull request looks pretty good.. one small comment in the discussion
Attachment #610102 - Flags: review?(warner-bugzilla) → review+
Priority: -- → P1
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a10fcb827d4ea2a5c4df1861d944f47dbe44d3ca
Bug 739957 - More than 2 lines strings in .properties files are broken.
+ report error on empty keys

https://github.com/mozilla/addon-sdk/commit/115115d13e6b07402984dcb393492dc68cb8a7d2
Merge pull request #390 from ochameau/fix-multiline-properties

Bug 739957 - More than 2 lines strings in .properties files are broken. r=@warner
Target Milestone: --- → 1.7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.