739962 - fix -Wunused-but-set-variable warnings in content/

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Nathan Froyd [:froydnj]]

/home/froydnj/src/m-c.git/content/base/src/nsContentUtils.cpp: In static member function 'static void nsContentUtils::InitializeModifierStrings()':
/home/froydnj/src/m-c.git/content/base/src/nsContentUtils.cpp:488:12: warning: variable 'rv' set but not used [-Wunused-but-set-variable]
/home/froydnj/src/m-c.git/content/media/MediaResource.cpp: In member function 'void mozilla::MediaResource::MoveLoadsToBackground()':
/home/froydnj/src/m-c.git/content/media/MediaResource.cpp:1211:12: warning: variable 'rv' set but not used [-Wunused-but-set-variable]
/home/froydnj/src/m-c.git/content/media/MediaResource.cpp: In member function 'void mozilla::MediaResource::ModifyLoadFlags(nsLoadFlags)':
/home/froydnj/src/m-c.git/content/media/MediaResource.cpp:1233:12: warning: variable 'rv' set but not used [-Wunused-but-set-variable]
/home/froydnj/src/m-c.git/content/media/nsBuiltinDecoderStateMachine.cpp: In member function 'virtual void nsBuiltinDecoderStateMachine::StartBuffering()':
/home/froydnj/src/m-c.git/content/media/nsBuiltinDecoderStateMachine.cpp:2166:30: warning: variable 'stats' set but not used [-Wunused-but-set-variable]
/home/froydnj/src/m-c.git/content/media/ogg/nsOggReader.cpp: In member function 'nsresult nsOggReader::SeekBisection(PRInt64, const nsOggReader::SeekRange&, PRUint32)':
/home/froydnj/src/m-c.git/content/media/ogg/nsOggReader.cpp:1168:15: warning: variable 'previousGuess' set but not used [-Wunused-but-set-variable]
/home/froydnj/src/m-c.git/content/base/src/nsEventSource.cpp: In member function 'virtual nsresult nsEventSource::Observe(nsISupports*, const char*, const PRUnichar*)':
/home/froydnj/src/m-c.git/content/base/src/nsEventSource.cpp:470:12: warning: variable 'rv' set but not used [-Wunused-but-set-variable]
/home/froydnj/src/m-c.git/content/xbl/src/nsXBLDocumentInfo.cpp: In member function 'void nsXBLDocGlobalObject::SetContext(nsIScriptContext*)':
/home/froydnj/src/m-c.git/content/xbl/src/nsXBLDocumentInfo.cpp:275:12: warning: variable 'rv' set but not used [-Wunused-but-set-variable]

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 610107 [details] [diff] [review]
patch

Review of attachment 610107 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/nsBuiltinDecoderStateMachine.cpp
@@ +2162,5 @@
>    UpdateReadyState();
>    mState = DECODER_STATE_BUFFERING;
>    LOG(PR_LOG_DEBUG, ("%p Changed state from DECODING to BUFFERING, decoded for %.3lfs",
>                       mDecoder.get(), decodeDuration.ToSeconds()));
> +  DebugOnly<nsMediaDecoder::Statistics> stats = mDecoder->GetStatistics();

You'll need an #ifdef that matches PR_LOG

Comment 3

[Nathan Froyd [:froydnj]]

Attachment: patch

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 610110 [details] [diff] [review]
patch

Good point, now to get Bugzilla to behave...

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Comment on attachment 610110 [details] [diff] [review]
patch

r=me assuming this all compiles and such :)

Comment 6

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6654f183d214

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/6654f183d214