Regression: Fixedpoint division in blur code was replaced to integer division

RESOLVED FIXED in mozilla14

Status

()

Core
Graphics
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Tetsuro Kato (tete), Assigned: Joe Drew (not getting mail))

Tracking

({regression})

Trunk
mozilla14
regression
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120312181643

Steps to reproduce:

In Bug 685767, we moved innards of gfxAlphaBoxBlur to mozilla::gfx::AlphaBoxBlur.


Actual results:

Fixedpoint division introduced by Bug 633627 was replaced to integer division by Bug 685767.


Expected results:

We should apply the patch of fixedpoint division of Bug 633627 again.
(Reporter)

Updated

5 years ago
Component: Untriaged → Graphics
Depends on: 685767, 633627
Keywords: regression
OS: Windows 7 → All
Product: Firefox → Core
Hardware: x86_64 → All
(Reporter)

Updated

5 years ago
No longer depends on: 633627, 685767
Assignee: nobody → joe
(Assignee)

Updated

5 years ago
QA Contact: untriaged → thebes
(Assignee)

Comment 1

5 years ago
Created attachment 610225 [details] [diff] [review]
port fixed point division to blur changes

This is just taking the patch from bug 633627 and applying it to gfx/2d/Blur.cpp.
Attachment #610225 - Flags: review?(jmuizelaar)
(Assignee)

Updated

5 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #610225 - Flags: review?(jmuizelaar) → review+
(Reporter)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/08deea54b324
Flags: in-testsuite?
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/08deea54b324
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.