Last Comment Bug 740067 - Make CreateNeededTablePseudos return void
: Make CreateNeededTablePseudos return void
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Daniel Holbert [:dholbert]
:
: Jet Villegas (:jet)
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-28 11:22 PDT by Daniel Holbert [:dholbert]
Modified: 2012-03-29 08:52 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (4.72 KB, patch)
2012-03-28 11:52 PDT, Daniel Holbert [:dholbert]
bzbarsky: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2012-03-28 11:22:58 PDT
I just noticed that CreateNeededTablePseudos (in nsCSSFrameConstructor) only ever returns NS_OK.

So, it doesn't need its nsresult return value -- it can just return void.
Comment 1 Daniel Holbert [:dholbert] 2012-03-28 11:52:35 PDT
Created attachment 610228 [details] [diff] [review]
fix

Trivial fix. Verified that it compiles locally.
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2012-03-28 12:08:00 PDT
Comment on attachment 610228 [details] [diff] [review]
fix

r=me
Comment 3 Daniel Holbert [:dholbert] 2012-03-28 12:44:02 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee3a013ecc89
Comment 4 Marco Bonardo [::mak] 2012-03-29 08:52:19 PDT
https://hg.mozilla.org/mozilla-central/rev/ee3a013ecc89

Note You need to log in before you can comment on or make changes to this bug.