740118 - Door-hangers de-attach from directional arrow when scrolling through list

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (03/28)

See attached screenshot.

STR: 

i) Load bug URL
ii) Rotate to landscape
iii) Scroll through prompt listings

--
Nightly (03/28)
Samsung Galaxy Nexus (Android; Mobile; rv:14.0) Gecko/14.0 Firefox/14.0a1

Comment 1

[Aaron Train [:aaronmt]]

I guess they don't 'de-attach'; the body of the dialog fades away out of view -- kind of weird

Comment 2

[Kevin Brosnan [Ex-Mozilla]]

This looks bad and doorhangers are somewhat common ui.

Comment 3

[:Margaret Leibovic]

(In reply to Kevin Brosnan [:kbrosnan] from comment #2)
> This looks bad and doorhangers are somewhat common ui.

Although they're common, you need to have multiple notifications appear for this to happen, and that's more rare.

I believe Sriram did the styling on these, maybe he knows a simple fix.

Comment 4

[Aaron Train [:aaronmt]]

(In reply to Margaret Leibovic [:margaret] from comment #3)
> (In reply to Kevin Brosnan [:kbrosnan] from comment #2) 
> Although they're common, you need to have multiple notifications appear for
> this to happen, and that's more rare.

Two fill up a small-screen device

Comment 5

[:Margaret Leibovic]

Attachment: patch

Moving the background from the LinearLayout to the ScrollView fixes the problem.

Comment 6

[:Margaret Leibovic]

Attachment: screenshot in overflow state

This is what happens in the overflow state with my patch applied.

Comment 7

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9cc500d2e6c8

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/9cc500d2e6c8

Comment 9

[:Margaret Leibovic]

Comment on attachment 611546 [details] [diff] [review]
patch

[Approval Request Comment]
Mobile only. Release blocker.

Comment 10

[Alex Keybl [:akeybl]]

Comment on attachment 611546 [details] [diff] [review]
patch

[Triage Comment]
Mobile only & blocking Fennec 1.0. Approved for Aurora 13.

Comment 11

[Martijn Wargers (dead)]

Verified fixed in today's build on the Samsung Galaxy Nexus.