Closed
Bug 740120
Opened 13 years ago
Closed 13 years ago
text-transform:lowercase should use conditional mapping for Greek sigma
Categories
(Core :: Layout: Text and Fonts, defect)
Core
Layout: Text and Fonts
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jfkthame, Assigned: jfkthame)
Details
(Keywords: dev-doc-complete, intl)
Attachments
(2 files, 1 obsolete file)
1.98 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
6.82 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
Applying text-transform:lowercase to Greek text currently converts Σ to σ in all cases. However, when the sigma is word-final, it should be converted to ς instead. See http://dev.w3.org/csswg/css3-text/#text-transform, and SpecialCasing.txt in the Unicode Character Database. In general terms, the mapping for Σ should be to σ whenever there is a following Greek letter, or when the character Σ occurs in isolation; and to ς when it is preceded by another letter but not followed by one. (Compare also bug 307039 regarding the Greek uppercase transform.)
Assignee | ||
Comment 1•13 years ago
|
||
This should provide a decent approximation of the required behavior. I note that Safari already implements something similar, BTW. We'll want a reftest to go with this...
Attachment #612511 -
Flags: review?(smontagu)
Assignee | ||
Comment 2•13 years ago
|
||
Simple reftest for the Sigma behavior. Matches webkit behavior for these testcases.
Attachment #612519 -
Flags: review?(smontagu)
Comment 3•13 years ago
|
||
Comment on attachment 612511 [details] [diff] [review] patch, use contextual lowercasing for Greek sigma Review of attachment 612511 [details] [diff] [review]: ----------------------------------------------------------------- I'm finding this a little hard to follow and needing to use the reftests as documentation for the code. Can you add comments specifying in which cases we're converting to final sigma and which not (as in comment 0, but in-source)?
Assignee | ||
Comment 4•13 years ago
|
||
I've added comments to try and explain better what's being done - hope this makes it easier to follow.
Attachment #612511 -
Attachment is obsolete: true
Attachment #612511 -
Flags: review?(smontagu)
Attachment #615134 -
Flags: review?(smontagu)
Updated•13 years ago
|
Attachment #615134 -
Flags: review?(smontagu) → review+
Updated•13 years ago
|
Attachment #612519 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e895a0f5ccb https://hg.mozilla.org/integration/mozilla-inbound/rev/d191234ca2fe
Assignee: nobody → jfkthame
Target Milestone: --- → mozilla14
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2e895a0f5ccb https://hg.mozilla.org/mozilla-central/rev/d191234ca2fe
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Keywords: dev-doc-needed
Comment 7•13 years ago
|
||
I've updated https://developer.mozilla.org/en/CSS/text-transform (summary, examples and the browser compatibility table). and added a note in: https://developer.mozilla.org/en/Firefox_14_for_developers
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•