The default bug view has changed. See this FAQ.

text-transform:lowercase should use conditional mapping for Greek sigma

RESOLVED FIXED in mozilla14

Status

()

Core
Layout: Text
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

({dev-doc-complete, intl})

unspecified
mozilla14
dev-doc-complete, intl
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Applying text-transform:lowercase to Greek text currently converts Σ to σ in all cases. However, when the sigma is word-final, it should be converted to ς instead.

See http://dev.w3.org/csswg/css3-text/#text-transform, and SpecialCasing.txt in the Unicode Character Database.

In general terms, the mapping for Σ should be to σ whenever there is a following Greek letter, or when the character Σ occurs in isolation; and to ς when it is preceded by another letter but not followed by one.

(Compare also bug 307039 regarding the Greek uppercase transform.)
(Assignee)

Comment 1

5 years ago
Created attachment 612511 [details] [diff] [review]
patch, use contextual lowercasing for Greek sigma

This should provide a decent approximation of the required behavior. I note that Safari already implements something similar, BTW.

We'll want a reftest to go with this...
Attachment #612511 - Flags: review?(smontagu)
(Assignee)

Comment 2

5 years ago
Created attachment 612519 [details] [diff] [review]
reftest for contextual lowercasing of Sigma

Simple reftest for the Sigma behavior. Matches webkit behavior for these testcases.
Attachment #612519 - Flags: review?(smontagu)
Comment on attachment 612511 [details] [diff] [review]
patch, use contextual lowercasing for Greek sigma

Review of attachment 612511 [details] [diff] [review]:
-----------------------------------------------------------------

I'm finding this a little hard to follow and needing to use the reftests as documentation for the code. Can you add comments specifying in which cases we're converting to final sigma and which not (as in comment 0, but in-source)?
(Assignee)

Comment 4

5 years ago
Created attachment 615134 [details] [diff] [review]
patch, use contextual lowercasing for Greek sigma - enhanced comments

I've added comments to try and explain better what's being done - hope this makes it easier to follow.
Attachment #612511 - Attachment is obsolete: true
Attachment #612511 - Flags: review?(smontagu)
Attachment #615134 - Flags: review?(smontagu)
Attachment #615134 - Flags: review?(smontagu) → review+
Attachment #612519 - Flags: review?(smontagu) → review+
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e895a0f5ccb
https://hg.mozilla.org/integration/mozilla-inbound/rev/d191234ca2fe
Assignee: nobody → jfkthame
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/2e895a0f5ccb
https://hg.mozilla.org/mozilla-central/rev/d191234ca2fe
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Keywords: dev-doc-needed
I've updated https://developer.mozilla.org/en/CSS/text-transform (summary, examples and the browser compatibility table).
and added a note in: https://developer.mozilla.org/en/Firefox_14_for_developers
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.