Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Screen orientation needs a specific security model for installed web apps

RESOLVED FIXED in mozilla15

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

({dev-doc-needed})

Trunk
mozilla15
dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

1.43 KB, patch
Justin Lebar (not reading bugmail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Right now we can't know if a web app is installed or not from C++ (bug 725397) but as soon as we can, we should allow them to change the orientation as they want (ie. no need to be fullscreen).
Also, we might have to handle a default orientation value. Right now, we always revert to Firefox Mobile default orientation when ORIENTATION_NONE is used but we will have to use the app default orientation instead.
(Assignee)

Updated

5 years ago
Keywords: dev-doc-needed
(Assignee)

Updated

5 years ago
Depends on: 753978
(Assignee)

Updated

5 years ago
Summary: Need a specific security model for installed web apps → Screen orientation needs a specific security model for installed web apps
(Assignee)

Comment 1

5 years ago
Created attachment 622859 [details] [diff] [review]
Patch v1
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #622859 - Flags: review?(justin.lebar+bug)
Comment on attachment 622859 [details] [diff] [review]
Patch v1

Review of attachment 622859 [details] [diff] [review]:
-----------------------------------------------------------------

>-    bool fullscreen;
>-    doc->GetMozFullScreen(&fullscreen);
>-    if (!fullscreen) {
>-      *aReturn = false;
>-      return NS_OK;
>+    // Non-app need to be fullscreen.
>+    if (!static_cast<nsGlobalWindow*>(GetOwner())->IsPartOfApp()) {
>+      bool fullscreen;
>+      doc->GetMozFullScreen(&fullscreen);
>+      if (!fullscreen) {
>+        *aReturn = false;
>+        return NS_OK;
>+      }
>     }

Make the comment positive, please:

 Apps and frames contained in apps can lock orientation.  But non-apps can lock orientation only if they're fullscreen.
Attachment #622859 - Flags: review?(justin.lebar+bug) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/mozilla-central/rev/c3b5e70e85e7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
(Assignee)

Updated

5 years ago
Depends on: 766902
You need to log in before you can comment on or make changes to this bug.