Closed
Bug 740192
Opened 13 years ago
Closed 13 years ago
Screen orientation needs a specific security model for installed web apps
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla15
People
(Reporter: mounir, Assigned: mounir)
References
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
1.43 KB,
patch
|
justin.lebar+bug
:
review+
|
Details | Diff | Splinter Review |
Right now we can't know if a web app is installed or not from C++ (bug 725397) but as soon as we can, we should allow them to change the orientation as they want (ie. no need to be fullscreen).
Also, we might have to handle a default orientation value. Right now, we always revert to Firefox Mobile default orientation when ORIENTATION_NONE is used but we will have to use the app default orientation instead.
Assignee | ||
Updated•13 years ago
|
Keywords: dev-doc-needed
Assignee | ||
Updated•13 years ago
|
Summary: Need a specific security model for installed web apps → Screen orientation needs a specific security model for installed web apps
Assignee | ||
Comment 1•13 years ago
|
||
Assignee: nobody → mounir
Status: NEW → ASSIGNED
Attachment #622859 -
Flags: review?(justin.lebar+bug)
Comment 2•13 years ago
|
||
Comment on attachment 622859 [details] [diff] [review]
Patch v1
Review of attachment 622859 [details] [diff] [review]:
-----------------------------------------------------------------
>- bool fullscreen;
>- doc->GetMozFullScreen(&fullscreen);
>- if (!fullscreen) {
>- *aReturn = false;
>- return NS_OK;
>+ // Non-app need to be fullscreen.
>+ if (!static_cast<nsGlobalWindow*>(GetOwner())->IsPartOfApp()) {
>+ bool fullscreen;
>+ doc->GetMozFullScreen(&fullscreen);
>+ if (!fullscreen) {
>+ *aReturn = false;
>+ return NS_OK;
>+ }
> }
Make the comment positive, please:
Apps and frames contained in apps can lock orientation. But non-apps can lock orientation only if they're fullscreen.
Attachment #622859 -
Flags: review?(justin.lebar+bug) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in
before you can comment on or make changes to this bug.
Description
•