740236 - If user changes PayPal ID without granting refund permissions, move the app to incomplete/disabled status

Status: RESOLVED WONTFIX

(Marketplace Graveyard :: Payments/Refunds, defect, P4)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Pick one of your public apps
2. Change PayPal id without granting refund status as in https://marketplace-dev.allizom.org/en-US/developers/app/seavans-undersea-adventure-3/paypal/
3. Notice that the app is still available in our gallery/search results


expected behavior:
App moves to incomplete/disabled status and is not listed publicly.

observed behavior:
App is listed publicly. User can purchase the app. However, upo requesting refund we get a traceback- PaypalError: Bad refund status for [e-mail]: NOT_PROCESSED

Comment 1

[Christopher Van Wiemeersch [:cvan]]

This is probably a matter of modifying the currency checker cronjob for bug 719201.

Comment 2

[Andy McKay]

The cronjob checker will catch it, but we shouldn't have to wait for the cronjob to catch it. If an app is public:

- we should put a note saying that doing this will disable the app until the refund permission is set up
- if they continue we should change it to disabled immediately
- when refund status is set up, move it back into public? or back into the review queue?, check highest status maybe?)

Comment 3

[Wil Clouser [:clouserw]]

> - when refund status is set up, move it back into public? or back into the
> review queue?, check highest status maybe?)

highest status sounds good so we can put it back where it was

Comment 4

[Wil Clouser [:clouserw]]

(In reply to Andy McKay [:andym] from comment #2)
> The cronjob checker will catch it, but we shouldn't have to wait for the
> cronjob to catch it. If an app is public:
> 
> - we should put a note saying that doing this will disable the app until the
> refund permission is set up
> - if they continue we should change it to disabled immediately
> - when refund status is set up, move it back into public? or back into the
> review queue?, check highest status maybe?)

It should move back to highest status.  Also, it doesn't need to be disabled for this, but it should be marked incomplete.