Closed Bug 740244 Opened 8 years ago Closed 8 years ago

We should not compile glx test when EGL provider enabled

Categories

(Core :: Graphics, defect)

ARM
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: romaxa, Assigned: romaxa)

Details

Attachments

(1 file, 1 obsolete file)

After GLProvider define and cleanup I guess we can define glx test compilation more nicely, only when GLX provider enabled
Attachment #610404 - Flags: review?(joe)
Comment on attachment 610404 [details] [diff] [review]
Don't build glx test on non GLX platform

Review of attachment 610404 [details] [diff] [review]:
-----------------------------------------------------------------

lovely
Attachment #610404 - Flags: review?(joe) → review+
Keywords: checkin-needed
Target Milestone: --- → mozilla14
Assignee: nobody → romaxa
47571 INFO TEST-START | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html
++DOMWINDOW == 306 (0x5acf488) [serial = 1084] [outer = 0x48d5ca0]
++DOCSHELL 0x9bd69b0 == 7 [id = 230]
++DOMWINDOW == 307 (0x7048b88) [serial = 1085] [outer = (nil)]
WARNING: Subdocument container has no frame: file /builds/slave/m-in-lnx64-dbg/build/layout/base/nsDocumentViewer.cpp, line 2442
++DOMWINDOW == 308 (0x70498f8) [serial = 1086] [outer = 0x7048b10]
JavaScript warning: http://mochi.test:8888/tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html, line 382: WebGL: Can't get a usable WebGL context
JavaScript warning: http://mochi.test:8888/tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html, line 382: WebGL: Can't get a usable WebGL context
47572 ERROR TEST-UNEXPECTED-FAIL | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | Can't create a WebGL context
47573 INFO TEST-END | /tests/content/canvas/test/webgl/test_webgl_conformance_test_suite.html | finished in 196ms
Depends on: 741166
No longer depends on: 741166
Keywords: checkin-needed
This orange means that the feature test for GLX didn't work and glxtest got disabled also on GLX, causing WebGL to be blacklisted.
Ok, I see where is the problem
Keywords: checkin-needed
Ok, this version should be better, will check it on try first
Attachment #610404 - Attachment is obsolete: true
Try build for latest version
https://tbpl.mozilla.org/?tree=Try&rev=a413d468523a
Attachment #613732 - Flags: review?(bjacob)
Attachment #613732 - Flags: review?(bjacob) → review+
Keywords: checkin-needed
Side note: when you will want to turn on driver blacklisting on Meego, go in widget/xpwidget/GfxInfoX11.cpp, search for #ifdef MOZ_PLATFORM_MAEMO, replace that by a check for USE_GLX_TEST.
Backed out whole merge for bustage per Yoric (Bug 743574):

https://hg.mozilla.org/integration/mozilla-inbound/rev/12e42fb8e321
Target Milestone: mozilla14 → ---
Disregard that; PEBKAC. Did not get backed out. I misread TBPL.
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/2b5c840841c1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.