Closed
Bug 740324
Opened 12 years ago
Closed 12 years ago
cubeb_winmm.c fails to compile on GCC
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
858 bytes,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
After landing 731807, GUID KSDATAFORMAT_SUBTYPE_PCM (and GUID KSDATAFORMAT_SUBTYPE_IEEE_FLOAT) are declared as static const ub cubeb_winmm.c, while they are still declared as extern const in mmreg.h. GCC complains that those declarations conflict. It's surprising MSVC doesn't. Removing static fixes the problem.
Attachment #610522 -
Flags: review?(jmathies)
|
||
Comment 1•12 years ago
|
||
Comment on attachment 610522 [details] [diff] [review] fix v1.0 sorry bout that.
Attachment #610522 -
Flags: review?(jmathies) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Thanks for the review. https://hg.mozilla.org/integration/mozilla-inbound/rev/2c4ec30ee406
Target Milestone: --- → mozilla14
|
||
Comment 3•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2c4ec30ee406
Assignee: nobody → jacek
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•