Last Comment Bug 740324 - cubeb_winmm.c fails to compile on GCC
: cubeb_winmm.c fails to compile on GCC
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla14
Assigned To: Jacek Caban
:
Mentors:
Depends on:
Blocks: 731807
  Show dependency treegraph
 
Reported: 2012-03-29 06:25 PDT by Jacek Caban
Modified: 2012-03-31 19:41 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (858 bytes, patch)
2012-03-29 06:25 PDT, Jacek Caban
jmathies: review+
Details | Diff | Splinter Review

Description Jacek Caban 2012-03-29 06:25:10 PDT
Created attachment 610522 [details] [diff] [review]
fix v1.0

After landing 731807, GUID KSDATAFORMAT_SUBTYPE_PCM (and GUID KSDATAFORMAT_SUBTYPE_IEEE_FLOAT) are declared as static const ub cubeb_winmm.c, while they are still declared as extern const in mmreg.h. GCC complains that those declarations conflict. It's surprising MSVC doesn't. Removing static fixes the problem.
Comment 1 Jim Mathies [:jimm] 2012-03-29 07:41:21 PDT
Comment on attachment 610522 [details] [diff] [review]
fix v1.0

sorry bout that.
Comment 2 Jacek Caban 2012-03-30 04:40:21 PDT
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c4ec30ee406
Comment 3 Ed Morley [:emorley] 2012-03-31 19:41:09 PDT
https://hg.mozilla.org/mozilla-central/rev/2c4ec30ee406

Note You need to log in before you can comment on or make changes to this bug.