Created attachment 610522 [details] [diff] [review]
After landing 731807, GUID KSDATAFORMAT_SUBTYPE_PCM (and GUID KSDATAFORMAT_SUBTYPE_IEEE_FLOAT) are declared as static const ub cubeb_winmm.c, while they are still declared as extern const in mmreg.h. GCC complains that those declarations conflict. It's surprising MSVC doesn't. Removing static fixes the problem.
Comment on attachment 610522 [details] [diff] [review]
sorry bout that.
Thanks for the review.