cubeb_winmm.c fails to compile on GCC

RESOLVED FIXED in mozilla14

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla14
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 610522 [details] [diff] [review]
fix v1.0

After landing 731807, GUID KSDATAFORMAT_SUBTYPE_PCM (and GUID KSDATAFORMAT_SUBTYPE_IEEE_FLOAT) are declared as static const ub cubeb_winmm.c, while they are still declared as extern const in mmreg.h. GCC complains that those declarations conflict. It's surprising MSVC doesn't. Removing static fixes the problem.
Attachment #610522 - Flags: review?(jmathies)

Comment 1

6 years ago
Comment on attachment 610522 [details] [diff] [review]
fix v1.0

sorry bout that.
Attachment #610522 - Flags: review?(jmathies) → review+
(Assignee)

Comment 2

6 years ago
Thanks for the review.

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c4ec30ee406
Target Milestone: --- → mozilla14

Comment 3

6 years ago
https://hg.mozilla.org/mozilla-central/rev/2c4ec30ee406
Assignee: nobody → jacek
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.