740359 - nsBrowserApp.cpp, APKOpen.cpp, webapprt.cpp are always rebuilt

Status: NEW

(Firefox Build System :: General, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This happens even when only changing java

Comment 1

[Jeff Muizelaar [:jrmuizel]]

This happens because APKOpen.cpp depends on application.ini.h

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Which depends on the buildid file which changes everytime we build.

Comment 3

[Mike Hommey [:glandium]]

And that's done on purpose.

Comment 4

[(not currently active) Ted Mielczarek]

We could add some configure variable, like ALWAYS_UPDATE_BUILDID, and set it in the tinderbox mozconfigs. With that unset, we wouldn't bother regenerating the BuildID for every build, only for clobbers.

Comment 7

[Nathan Froyd [:froydnj]]

This is the perfect sort of thing to configure under developer options.

I don't know if it will play nicely with e.g. startup caches and Fennec, though.

Comment 8

[Mike Hommey [:glandium]]

(In reply to Nathan Froyd (:froydnj) from comment #7)
> I don't know if it will play nicely with e.g. startup caches and Fennec,
> though.

It doesn't. Which is why we've been keeping it that way so far.