get rid nsIAccessible innerHTML method

RESOLVED FIXED in mozilla14

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: capella)

Tracking

({addon-compat, dev-doc-needed})

unspecified
mozilla14
addon-compat, dev-doc-needed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=eitan@monotonous.org][lang=c++])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
1) remove innerHTML method from nsIAccessible interface (http://mxr.mozilla.org/mozilla-central/source/accessible/public/nsIAccessible.idl?force=1#111)
2) bump uuid of nsIAccessible interface
3) remove GetInnerHTML implementation from nsAccessible and nsApplicationAccessible (see accessible/src/base folder)
4) move the logic of nsAccessible::GetInnerHTML to nsAccessNodeWrap::get_innerHTML (see accessible/src/msaa) where it's used
(In reply to alexander :surkov from comment #0)
> 1) remove innerHTML method from nsIAccessible interface
> (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> nsIAccessible.idl?force=1#111)

any particular reason you want to remove this method?  it doesn't completely make sense or really have a clear purpose,but it doesn't seem its really hurting any one either.

> 4) move the logic of nsAccessible::GetInnerHTML to
> nsAccessNodeWrap::get_innerHTML (see accessible/src/msaa) where it's used

it looks like it already uses its own logic which is the same.  Although perhaps it should use something other than qi and nsIDOMHTMLElement
(Reporter)

Comment 2

5 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #1)
> (In reply to alexander :surkov from comment #0)
> > 1) remove innerHTML method from nsIAccessible interface
> > (http://mxr.mozilla.org/mozilla-central/source/accessible/public/
> > nsIAccessible.idl?force=1#111)
> 
> any particular reason you want to remove this method?  it doesn't completely
> make sense or really have a clear purpose,but it doesn't seem its really
> hurting any one either.

this method is just a shortcut around HTML element innerHTML, doesn't make sense to dupe it on accessibility layer

> > 4) move the logic of nsAccessible::GetInnerHTML to
> > nsAccessNodeWrap::get_innerHTML (see accessible/src/msaa) where it's used
> 
> it looks like it already uses its own logic which is the same.  Although
> perhaps it should use something other than qi and nsIDOMHTMLElement

you're right, I missed that (it was late night for me :) ) So no 4) item.
(Assignee)

Updated

5 years ago
Assignee: nobody → markcapella
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 years ago
Created attachment 610983 [details] [diff] [review]
Patch (v1)

Looks fairly simple, built out ok, passed all mochitest-a11y tests ...
Attachment #610983 - Flags: feedback?(trev.saunders)
Attachment #610983 - Flags: feedback?(trev.saunders) → review+
Keywords: dev-doc-needed
landed https://hg.mozilla.org/integration/mozilla-inbound/rev/57bd8957e1b4
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/57bd8957e1b4
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Reporter)

Updated

5 years ago
Keywords: addon-compat
You need to log in before you can comment on or make changes to this bug.