Closed Bug 740452 Opened 13 years ago Closed 13 years ago

client.mk: add a convenience target for check-sync-dirs so the test can be run independent of configure

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla14

People

(Reporter: joey, Assigned: joey)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → joey
Code consolidation and will be helpful for submission scripts to trap silly errors before they reach try.
Attachment #610587 - Flags: review?(ted.mielczarek)
Attachment #610587 - Attachment is patch: true
ping on the code review
Comment on attachment 610587 [details] [diff] [review] new target for check-sync-dirs so test can be run independent of configure Review of attachment 610587 [details] [diff] [review]: ----------------------------------------------------------------- ::: client.mk @@ +425,5 @@ > +## Sanity check $X and js/src/$X are in sync > +.PHONY: check-sync-dirs > +check-sync-dirs: check-sync-dirs-build check-sync-dirs-config > +check-sync-dirs-%: > + @$(PYTHON) $(TOPSRCDIR)/js/src/config/check-sync-dirs.py $(TOPSRCDIR)/js/src/$(subst check-sync-dirs-,$(NULL),$@) $(TOPSRCDIR)/$(subst check-sync-dirs-,$(NULL),$@) Can't you just use $* here instead of this subst?
Attachment #610587 - Flags: review?(ted.mielczarek) → review+
(In reply to Ted Mielczarek [:ted] from comment #3) > Comment on attachment 610587 [details] [diff] [review] > new target for check-sync-dirs so test can be run independent of configure > > Review of attachment 610587 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: client.mk > @@ +425,5 @@ > > +## Sanity check $X and js/src/$X are in sync > > +.PHONY: check-sync-dirs > > +check-sync-dirs: check-sync-dirs-build check-sync-dirs-config > > +check-sync-dirs-%: > > + @$(PYTHON) $(TOPSRCDIR)/js/src/config/check-sync-dirs.py $(TOPSRCDIR)/js/src/$(subst check-sync-dirs-,$(NULL),$@) $(TOPSRCDIR)/$(subst check-sync-dirs-,$(NULL),$@) > > Can't you just use $* here instead of this subst? Nice, yes that would do the trick and will be more efficient.
same patch as last time with $(subst ) replaced with $* per Ted's suggestion. r=ted
Attachment #610587 - Attachment is obsolete: true
Keywords: checkin-needed
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla14
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: