client.mk: add a convenience target for check-sync-dirs so the test can be run independent of configure

RESOLVED FIXED in mozilla14

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: joey, Assigned: joey)

Tracking

unspecified
mozilla14
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Updated

6 years ago
Assignee: nobody → joey
(Assignee)

Comment 1

6 years ago
Created attachment 610587 [details] [diff] [review]
new target for check-sync-dirs so test can be run independent of configure

Code consolidation and will be helpful for submission scripts to trap silly errors before they reach try.
Attachment #610587 - Flags: review?(ted.mielczarek)

Updated

6 years ago
Attachment #610587 - Attachment is patch: true
(Assignee)

Comment 2

5 years ago
ping on the code review
Comment on attachment 610587 [details] [diff] [review]
new target for check-sync-dirs so test can be run independent of configure

Review of attachment 610587 [details] [diff] [review]:
-----------------------------------------------------------------

::: client.mk
@@ +425,5 @@
> +## Sanity check $X and js/src/$X are in sync
> +.PHONY: check-sync-dirs
> +check-sync-dirs: check-sync-dirs-build check-sync-dirs-config
> +check-sync-dirs-%:
> +	@$(PYTHON) $(TOPSRCDIR)/js/src/config/check-sync-dirs.py $(TOPSRCDIR)/js/src/$(subst check-sync-dirs-,$(NULL),$@) $(TOPSRCDIR)/$(subst check-sync-dirs-,$(NULL),$@)

Can't you just use $* here instead of this subst?
Attachment #610587 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Ted Mielczarek [:ted] from comment #3)
> Comment on attachment 610587 [details] [diff] [review]
> new target for check-sync-dirs so test can be run independent of configure
> 
> Review of attachment 610587 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: client.mk
> @@ +425,5 @@
> > +## Sanity check $X and js/src/$X are in sync
> > +.PHONY: check-sync-dirs
> > +check-sync-dirs: check-sync-dirs-build check-sync-dirs-config
> > +check-sync-dirs-%:
> > +	@$(PYTHON) $(TOPSRCDIR)/js/src/config/check-sync-dirs.py $(TOPSRCDIR)/js/src/$(subst check-sync-dirs-,$(NULL),$@) $(TOPSRCDIR)/$(subst check-sync-dirs-,$(NULL),$@)
> 
> Can't you just use $* here instead of this subst?

Nice, yes that would do the trick and will be more efficient.
(Assignee)

Comment 5

5 years ago
Created attachment 612624 [details] [diff] [review]
move check-sync-dirs test to a named target so it can be run indepen dent of configure

same patch as last time with $(subst ) replaced with $* per Ted's suggestion.
r=ted
Attachment #610587 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7ebb831c329
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/e7ebb831c329
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.