Closed
Bug 740452
Opened 13 years ago
Closed 13 years ago
client.mk: add a convenience target for check-sync-dirs so the test can be run independent of configure
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla14
People
(Reporter: joey, Assigned: joey)
Details
Attachments
(1 file, 1 obsolete file)
No description provided.
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → joey
Assignee | ||
Comment 1•13 years ago
|
||
Code consolidation and will be helpful for submission scripts to trap silly errors before they reach try.
Attachment #610587 -
Flags: review?(ted.mielczarek)
Updated•13 years ago
|
Attachment #610587 -
Attachment is patch: true
Assignee | ||
Comment 2•13 years ago
|
||
ping on the code review
Comment 3•13 years ago
|
||
Comment on attachment 610587 [details] [diff] [review]
new target for check-sync-dirs so test can be run independent of configure
Review of attachment 610587 [details] [diff] [review]:
-----------------------------------------------------------------
::: client.mk
@@ +425,5 @@
> +## Sanity check $X and js/src/$X are in sync
> +.PHONY: check-sync-dirs
> +check-sync-dirs: check-sync-dirs-build check-sync-dirs-config
> +check-sync-dirs-%:
> + @$(PYTHON) $(TOPSRCDIR)/js/src/config/check-sync-dirs.py $(TOPSRCDIR)/js/src/$(subst check-sync-dirs-,$(NULL),$@) $(TOPSRCDIR)/$(subst check-sync-dirs-,$(NULL),$@)
Can't you just use $* here instead of this subst?
Attachment #610587 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Ted Mielczarek [:ted] from comment #3)
> Comment on attachment 610587 [details] [diff] [review]
> new target for check-sync-dirs so test can be run independent of configure
>
> Review of attachment 610587 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> ::: client.mk
> @@ +425,5 @@
> > +## Sanity check $X and js/src/$X are in sync
> > +.PHONY: check-sync-dirs
> > +check-sync-dirs: check-sync-dirs-build check-sync-dirs-config
> > +check-sync-dirs-%:
> > + @$(PYTHON) $(TOPSRCDIR)/js/src/config/check-sync-dirs.py $(TOPSRCDIR)/js/src/$(subst check-sync-dirs-,$(NULL),$@) $(TOPSRCDIR)/$(subst check-sync-dirs-,$(NULL),$@)
>
> Can't you just use $* here instead of this subst?
Nice, yes that would do the trick and will be more efficient.
Assignee | ||
Comment 5•13 years ago
|
||
same patch as last time with $(subst ) replaced with $* per Ted's suggestion.
r=ted
Attachment #610587 -
Attachment is obsolete: true
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Comment 6•13 years ago
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•